Limit the number of informational responses per request - #319
Open
hsbt wants to merge 1 commit into
Open
Conversation
A peer that keeps sending 1xx responses keeps the client in the read loop of transport_request indefinitely, since the per-response header limit resets for each response. Cap the count at 100, the same value CPython's http.client uses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transport_requestreads informational (1xx) responses in a loop with no bound on the count.MAX_RESPONSE_HEADER_LENGTHonly limits each response individually, so a peer that keeps sending interim responses keeps the client in the loop indefinitely.read_timeoutdoes not help because it only applies to a single read. This addsNet::HTTPResponse::MAX_INFORMATIONAL_RESPONSES, set to 100, and raisesNet::HTTPBadResponsewhen a request receives more than that before the final response. CPython'shttp.clientuses the same value (_MAXINTERIMRESPONSES). With this cap the total header size per request is also bounded.