ssl: keep original SSLContext alive after servername_cb - #1090
Closed
rhenium wants to merge 1 commit into
Closed
Conversation
Keep the original SSLContext in a separate instance variable to prevent it from being GC'ed. When the SNI callback accepts the provided server name, it may replace the SSL_CTX with SSL_set_SSL_CTX() and update SSLSocket#context. However, despite its name, SSL_set_SSL_CTX() does not use all parameters from the new SSL_CTX. In particular, callbacks set by the original SSL_CTX remain in use and therefore require the corresponding SSLContext object to stay alive.
Member
Author
|
This turned out not to be needed for now, so I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the original
SSLContextin a separate instance variable to prevent it from being GC'ed.When the SNI callback accepts the provided server name, it may replace the
SSL_CTXwithSSL_set_SSL_CTX()and updateSSLSocket#context. However, despite its name,SSL_set_SSL_CTX()does not use all parameters from the newSSL_CTX. In particular, callbacks set by the originalSSL_CTXremain in use and therefore require the correspondingSSLContextobject to stay alive.Noticed while reviewing #1089.