Show the newest out-of-cooldown version in bundle outdated - #9803
Merged
Conversation
With cooldown enabled, "newest" is often a version still inside the cooldown window and the newest version bundler would actually adopt was not shown anywhere. Append it to the outdated line, both in the parseable output and in the table, when it sits strictly between the installed version and the newest one. Existing tokens are left untouched so tools parsing this output (e.g. libyear-bundler) keep working. Closes #9624 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The table said "1.5.0 available", but "available" already denotes the opposite state in the install summary, which reports a blocked version as "(available in 6 days)". Reuse the exact antonym of the prose "in cooldown for N more days" instead, so both formats name the concept the same way. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The man page enumerates the cooldown output tokens, so the two tokens added for #9624 belong there too. Review finding UX-1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The candidate list was recomputed for the same gem by retrieve_active_spec and newest_out_of_cooldown. Review finding API-2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review finding GEM-1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
In strict mode the resolved version is already cooldown-filtered, so no cooldown annotations appear. Pin that down. Review finding UX-4. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
No test exercised the "1 more day" path. Review finding GEM-2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Unreachable today because specs_for_outdated_check yields one spec per name, but keying on the argument that feeds the computation keeps the cache honest. Review finding API-1 (round 2). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The resolver already pins its cooldown clock via cooldown_now; do the same here so every annotation in one run shares the same reference time. Review finding API-2 (round 2). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review finding UX-3 (round 2). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
They flip the same strict flag as --filter-strict, so the cooldown caveat applies to them too. Review finding UX-1 (round 3). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With cooldown enabled,
bundle outdatedreports the newest published version even when it is still inside the cooldown window, and the newest version bundler would actually adopt right now is not shown anywhere. Tools like libyear-bundler parse this output and currently have to look the adoptable version up elsewhere. This appends it to the outdated line when it sits strictly between the installed version and the in-cooldown newest one, in both the parseable output and the table. Existing tokens are untouched so parsers keep working, and when no adoptable update exists outside the window nothing is appended and the output stays byte-identical.Before:
After:
The table's Latest column gets the same information as
2.0.0 (cooldown 6d, 1.5.0 out of cooldown).Closes #9624