FIX: layout for stats & community view - #150
Merged
Merged
Conversation
The meetup redesign (PR rubyuy#146) rewrote _sass/view.scss and dropped the generic .view class in favor of #view-meetup-scoped rules, without noticing stats/community/talks/404 still depend on .view for their container width and spacing.
Member
|
gracias Agus! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.viewcontainer styles (width, margins, section/heading spacing) in_sass/view.scss.viewwith#view-meetup-scoped rules and accidentally deleted the shared class, so/stats/,/community/,/talks/and404.htmlrendered full-width with no paddingTest plan
bundle exec jekyll slocally, verified/stats/and/community/render with proper container width/margins again