Skip to content

Parity with other profilers - #6

Merged
colinjlacy merged 2 commits into
runtimeconditions:mainfrom
itvi-1234:parity-with-other-profilers
Nov 18, 2026
Merged

colinjlacy merged 2 commits into
runtimeconditions:mainfrom
itvi-1234:parity-with-other-profilers

Conversation

@itvi-1234

Copy link
Copy Markdown
Member

No description provided.

Remove archive/research-v1, about 2,300 lines of the first research prototype that no package, test or workflow
reads and whose own paths no longer exist; profiler.py, a seven-line copy of the console script, which the interop
plan already says profiling must not need; and the 0.1.0 core profile schema, which the profiler does not load (the
distribution carries only the 0.4.0 one). Add the MIT LICENSE the other profilers carry.
Found by running the profiler end to end on the real common-integrations and env-configuration bindings and comparing
with the Go, TypeScript and Java profilers.

- --version [--json] prints the name, version and core profile schemas (0.4.0). The rc command runs an add-on only
  after reading this, so without it rc profile python could not work.
- The profile word is optional: generate and verify-bindings work on their own, so rc can pass them straight through.
- --workload-version is optional, as in the TypeScript and Java profilers; without it the profile has no
  workload.version. It was required.
- The YAML indents a list under its key ("  - item"), keeps non-ASCII names as written and never folds a long value,
  as the other profilers do. The output for the same declarations is now byte for byte the Java profiler's.
- verify-bindings marks the packages only a dependency of the imports with (dependency) and a direct flag in the JSON,
  which also gives VerifiedBindingSet.imported_packages a use in the program, not only in a test.

Tested on the real packages: one workload that declares an api, a datastore and a cache with environment
configuration gives exactly the profile the Java profiler's tests review. Six new tests; the writer tests fail without
the writer change. 119 tests pass.
@colinjlacy
colinjlacy merged commit 292a0b5 into runtimeconditions:main Nov 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants