IndexMap::retain: Fix unsoundness in the context of panicking predicate - #689
Merged
Merged
Conversation
sgued
changed the title
Contributor
Author
|
Looks like miri doesn't like the fix by itself. I'll take a deeper look later. |
This was referenced Sep 14, 2026
Contributor
Author
|
The CI was broken with miri because |
sgued
force-pushed
the
indexmap
branch
2 times, most recently
from
September 14, 2026 20:22
6115b08 to
07c8972
Compare
zeenix
requested changes
Sep 15, 2026
| .entries | ||
| .retain_mut(|entry| keep(&mut entry.key, &mut entry.value)); | ||
|
|
||
| self.reinsert_all(); |
Contributor
There was a problem hiding this comment.
This should now be removed? 🤔
Contributor
Author
There was a problem hiding this comment.
Right, removed it and force-pushed.
Miri didn't like the two borrowing made of the `v` field since the second mutable borrow would invalidate any borrow and thus the pointers from the first non mutable borrow. This can be fixed by just borrowing once mutably and then only manipulating pointers. Closes rust-embedded#690
zeenix
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #688