Remove -Zasymmetric-token / cargo:paseto - #17486
Merged
Merged
Conversation
This feature has been stale for s significant time. Since then, we've decided to improve security through: - trusted publishing - deprecating storing tokens in plain text, preferring OS native credential stores Keeping it around has costs: - build time - test time - needs to be taken into account for any config system refactors See also https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/Should.20we.20drop.20paseto.3F/with/624770308
rustbot
added
A-configuration
Collaborator
|
r? @Muscraft rustbot has assigned @Muscraft. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-unstable
epage
commented
Sep 17, 2026
Comment on lines
-723
to
670
| struct Mutation<'a> { | ||
| mutation: &'a str, | ||
| name: Option<&'a str>, | ||
| vers: Option<&'a str>, | ||
| cksum: Option<&'a str>, | ||
| } | ||
| struct Mutation {} | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I figured Some(Mutation) | None made intent in APIs more clear than true | false so I kept the struct around. I also considered an enum but felt this worked just as well and minimized the change
epage
commented
Sep 17, 2026
| // Please keep this list lexicographically ordered. | ||
| advanced_env: bool, | ||
| any_build_script_metadata: bool = ("Allow any build script to specify env vars via cargo::metadata=key=value"), | ||
| asymmetric_token: bool = ("Allows authenticating with asymmetric tokens"), |
Contributor
Author
There was a problem hiding this comment.
I'm not seeing precedence fr removing a -Z besides stabilization. I could instead keep it and error on use. I started the PR in the simpler state.
Member
There was a problem hiding this comment.
I looked into what rustc does in this scenario and it appears they just go ahead and remove the -Z flag.
Muscraft
approved these changes
Sep 17, 2026
rustbot
removed
the
S-waiting-on-review
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This feature has been stale for s significant time. Since then, we've decided to improve security through:
Keeping it around has costs:
See also https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/Should.20we.20drop.20paseto.3F/with/624770308
How to test and review this PR?
LLM disclosure: the initial draft was written by an LLM which I then reviewed and changed. @weihanglo has agreed to review this.