Skip to content

WIP: add retries to fastly api requests, use same retry logic for registry api - #3417

Draft
syphar wants to merge 1 commit into
rust-lang:mainfrom
syphar:fastly-retry
Draft

WIP: add retries to fastly api requests, use same retry logic for registry api#3417
syphar wants to merge 1 commit into
rust-lang:mainfrom
syphar:fastly-retry

Conversation

@syphar

@syphar syphar commented Jul 24, 2026

Copy link
Copy Markdown
Member

to fix errors like this sentry error

  • fastly api requests weren't retried before, we have some sentry errors where content was outdated because of that.
  • registry api retries where just retried for all possible errors. the reqwest-retry logic only retries transient errors, which would reduce load on crates.io.

With this middleware we get retries just for "transient" errors, and niceties like jittering.

When the repackage & #3414 is done we then can remove our custom retry_async method.

the default retry strategy is explained here:

@syphar syphar self-assigned this Jul 24, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jul 24, 2026
@syphar
syphar force-pushed the fastly-retry branch 2 times, most recently from e5cc053 to cb1678e Compare July 25, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant