Remove term "indirection" and its derivatives - #715
Merged
Merged
Conversation
kirtchev-adacore
force-pushed
the
mr/fls-710-remove-indirection
branch
2 times, most recently
from
July 28, 2026 07:52
d8a34a8 to
5f464ca
Compare
kirtchev-adacore
marked this pull request as ready for review
July 28, 2026 07:54
PLeVasseur
requested changes
Aug 7, 2026
Contributor
There was a problem hiding this comment.
Thanks @kirtchev-adacore, for taking the time to adopt the Rust Project terminology.
I found a couple of places where we seem to be a bit at odds with what's written up in the Reference. Could you take a look?
This comment has been minimized.
This comment has been minimized.
kirtchev-adacore
force-pushed
the
mr/fls-710-remove-indirection
branch
from
August 31, 2026 07:33
5f464ca to
6b75ea5
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
kirtchev-adacore
force-pushed
the
mr/fls-710-remove-indirection
branch
from
August 31, 2026 07:55
6b75ea5 to
e4fb4a4
Compare
This PR removes the term "indirection" and its derivatives from the FLS as the Rust Project does not use this term. The preferred alternative is "pointer", "pointer type", etc. Closes: #710
kirtchev-adacore
force-pushed
the
mr/fls-710-remove-indirection
branch
from
August 31, 2026 08:06
e4fb4a4 to
69176c1
Compare
tshepang
reviewed
Aug 31, 2026
tshepang
approved these changes
Sep 1, 2026
PLeVasseur
previously requested changes
Sep 4, 2026
Contributor
There was a problem hiding this comment.
This looks like it took a great direction. Thanks @kirtchev-adacore!
There were a couple of procedural things I think need be taken care of, but otherwise we should merge:
- finalize the changelog updates
- maintaining the FLS ID whens shifting from one place in the FLS to another
tshepang
reviewed
Sep 4, 2026
tshepang
requested changes
Sep 4, 2026
tshepang
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the term "indirection" and its derivatives from the FLS as the Rust Project does not use this term. The preferred alternative is "pointer", "pointer type", etc.
Closes: #710