Skip to content

Remove term "indirection" and its derivatives - #715

Merged
tshepang merged 5 commits into
mainfrom
mr/fls-710-remove-indirection
Sep 4, 2026
Merged

tshepang merged 5 commits into
mainfrom
mr/fls-710-remove-indirection

Conversation

@kirtchev-adacore

Copy link
Copy Markdown
Contributor

This PR removes the term "indirection" and its derivatives from the FLS as the Rust Project does not use this term. The preferred alternative is "pointer", "pointer type", etc.

Closes: #710

@kirtchev-adacore
kirtchev-adacore force-pushed the mr/fls-710-remove-indirection branch 2 times, most recently from d8a34a8 to 5f464ca Compare July 28, 2026 07:52
@kirtchev-adacore
kirtchev-adacore marked this pull request as ready for review July 28, 2026 07:54
@kirtchev-adacore kirtchev-adacore self-assigned this Jul 28, 2026

@PLeVasseur PLeVasseur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kirtchev-adacore, for taking the time to adopt the Rust Project terminology.

I found a couple of places where we seem to be a bit at odds with what's written up in the Reference. Could you take a look?

View changes since this review

Comment thread src/types-and-traits.rst
Comment thread src/types-and-traits.rst Outdated
@rustbot

This comment has been minimized.

@kirtchev-adacore
kirtchev-adacore force-pushed the mr/fls-710-remove-indirection branch from 5f464ca to 6b75ea5 Compare August 31, 2026 07:33
@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@kirtchev-adacore
kirtchev-adacore force-pushed the mr/fls-710-remove-indirection branch from 6b75ea5 to e4fb4a4 Compare August 31, 2026 07:55
This PR removes the term "indirection" and its derivatives from the FLS
as the Rust Project does not use this term. The preferred alternative is
"pointer", "pointer type", etc.

Closes: #710
@kirtchev-adacore
kirtchev-adacore force-pushed the mr/fls-710-remove-indirection branch from e4fb4a4 to 69176c1 Compare August 31, 2026 08:06
Comment thread src/types-and-traits.rst
Comment thread src/types-and-traits.rst

@PLeVasseur PLeVasseur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it took a great direction. Thanks @kirtchev-adacore!

There were a couple of procedural things I think need be taken care of, but otherwise we should merge:

  • finalize the changelog updates
  • maintaining the FLS ID whens shifting from one place in the FLS to another

View changes since this review

Comment thread src/types-and-traits.rst
Comment thread src/values.rst Outdated
Comment thread src/changelog.rst Outdated
Comment thread src/changelog.rst Outdated
Comment thread src/changelog.rst Outdated
Comment thread src/changelog.rst Outdated
Comment thread src/changelog.rst Outdated
Comment thread src/changelog.rst Outdated
@tshepang
tshepang added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit a70c80e Sep 4, 2026
3 checks passed
@tshepang
tshepang deleted the mr/fls-710-remove-indirection branch September 4, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Change]: Remove the term "indirection", and associated derivatives

4 participants