Conversation
jhult
force-pushed
the
fix/css-url-rewriting
branch
from
March 16, 2026 19:25
f71812a to
cacc8f7
Compare
This comment has been minimized.
This comment has been minimized.
jhult
force-pushed
the
fix/css-url-rewriting
branch
from
April 22, 2026 00:29
cacc8f7 to
e375fc4
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
Sorry for the delay! We now have an mdbook team so review should hopefully be a bit faster. It's a big PR so I'll try to come back to it soon. |
| static_regex!( | ||
| CSS_URL, | ||
| bytes, | ||
| r#"url\(\s*(?:"([^"]*?)"|'([^']*?)'|([^'"\s()]+))\s*\)"# |
Member
There was a problem hiding this comment.
Instead of using a regex, why not add in the CSS files something like:
property: /* hashed-url-file: original-filename */;Like that we only need to look for /* hashed-url-file: and replace the given filename with its hashed version.
GuillaumeGomez
added
S-waiting-on-author
Collaborator
|
☔ The latest upstream changes (possibly #3222) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2958
When font files are hashed for cache-busting, CSS
url()references were not updated to use the hashed filenames, causing custom fonts to fail loading.This fix rewrites
url()references in CSS files duringwrite_files, handling all three quoting styles (url("…"),url('…'),url(…)), resolving paths relative to the CSS file's location before looking up in the hash map, and leaving absolute/data URLs untouched.