Conversation
|
Sorry for the delay, we now have an mdbook team so things should move a bit faster here. This sounds like a very good idea to add an example! Do you mind adding a GUI test to ensure that the code you provided won't become outdated when we make updates? |
|
Reminder, once the PR becomes ready for a review, use |
|
Thank you for your review. When I wrote this documentation, I understood that review bandwidth was extremely limited, If minor changes are acceptable, I can clean up some of the JavaScript hacks, what do you think? mdBook/crates/mdbook-html/src/html/tree.rs Line 1010 in 74b14bb the section titled "Restrict the .playground selector to <pre>" will no longer be necessary.
|
|
If that can make things simpler, then it's worth a try! |
|
I wrote 2 issues to improve custome playground support. |
|
@GuillaumeGomez Regarding #3216, since it would have a bit large impact, such as requiring the addition of a configuration value, If there is no prospect of it being accepted in the short term, I am also open to rewriting this guide on the assumption that #3216 can't be used. |
This PR documents how to implement custom playgrounds.
This is a successor to PR #2286.
The method described in #2286 is no longer available in v0.5, so it has been rewritten for v0.5, and
it was possible to implement it with fewer patches than the previous version.
Related: #350 #1453 #1759