fix: definition list in Chrome - #3219
Merged
GuillaumeGomez merged 1 commit intoSep 15, 2026
Merged
Conversation
Member
|
Seems good to me, thanks! Please add a GUI test. |
Contributor
Author
|
I don't know what should i check neither where / how i can check Do you have clues ? |
Member
|
If it's present in the text, you can check with |
Member
|
I couldn't figure out a way to check that with the GUI test as it's a CSS only value, computed by the web browser. So yeah... Please remove the last commit, I'll make one last review pass afterwards to confirm I didn't miss anything and then merge. |
pinage404
force-pushed
the
definition_list_fix_chrome
branch
from
September 15, 2026 11:40
44c15dd to
fd391c8
Compare
GuillaumeGomez
approved these changes
Sep 15, 2026
Member
|
Looks all good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
When there are several definitions (
<dd>) for a term (<dt>), definitions (<dd>) are prefixed with a numberWhen there are several terms with both several definitions, the number was not incremented the same way in Firefox and Chrome
Tested with version
0.5.4and the currentmainbranchThe behaviour was good with Firefox
But the number wasn't resettled with definition term (
<dt>) in ChromeI saw this warning on MDN
I tried to change in the code, it aligned the behaviour of Chrome on the Firefox
Code to reproduce the bug
# Example Foo : should be 1 : should be 2 : should be 3 Bar : should be 1 : should be 2 : should be 3 Before this patch : Works with : Zen Browser 1.21.16b (Firefox 154.0.1) (64 bits) : Does not work with : Chromium Version 152.0.7977.64 (Build officiel) After this patch : Works with : Zen Browser 1.21.16b (Firefox 154.0.1) (64 bits) : Chromium Version 152.0.7977.64 (Build officiel)Render :
I only tested on Linux with :
I didn't do any others checks