Enforce the absence of \\ in static files paths - #3223
Merged
Merged
Conversation
notriddle
reviewed
Sep 14, 2026
GuillaumeGomez
force-pushed
the
backslash
branch
from
September 15, 2026 09:19
b8458d8 to
a3bf152
Compare
Member
Author
|
Removed |
notriddle
reviewed
Sep 16, 2026
GuillaumeGomez
force-pushed
the
backslash
branch
from
September 16, 2026 16:27
a3bf152 to
7f124b9
Compare
Member
Author
|
Replaced the lifetime with |
GuillaumeGomez
force-pushed
the
backslash
branch
from
September 16, 2026 18:40
7f124b9 to
c435153
Compare
Member
Author
|
And fixed CI too. |
Contributor
|
@bors r+ |
Member
Author
|
No r+ in here, we need to click the merge button. ;) |
Member
Author
|
(And for that you need to approve the pull request first) |
notriddle
approved these changes
Sep 18, 2026
Contributor
|
:headdesk: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #3222.
This changes the code structure so that we now enforce through the type system that the static files "path" (used for hbs rendering) don't have
\on Windows.r? @notriddle