Skip to content

Buggy debuginfo test suite, or just function-names.rs? #126060

Open
Open
Buggy debuginfo test suite, or just function-names.rs?#126060
Labels
A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)C-bugCategory: This is a bug.O-windowsOperating system: WindowsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@workingjubilee
workingjubilee
opened on Jun 6, 2024

In #125958 (a PR which changes the way consts are handled in the compiler, and thus alters details like their hashing, etc.) a few lines were trimmed out of a debuginfo test because it was unreasonable to get it to work, despite the function names seemingly being present.

It seems like there might be a bug in the way that the debuginfo test suite handles [...]? Or it might incorrectly treat certain checks as ordering-sensitive, when hashing can change orders? It's unclear, but in any case, undesirable.

This mostly affected the Windows variant of the test.

Activity

  1. workingjubilee
    added
    O-windowsOperating system: Windows
    A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)
    C-bugCategory: This is a bug.
    on Jun 6, 2024
  2. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 6, 2024

  3. workingjubilee commented on Jun 6, 2024

    @workingjubilee
    workingjubilee
    on Jun 6, 2024
    MemberAuthor

    cc @michaelwoerister

  4. michaelwoerister
    self-assigned this
    on Jun 6, 2024

  5. michaelwoerister commented on Jun 6, 2024

    @michaelwoerister
    michaelwoerister
    on Jun 6, 2024
    Member

    Thanks for the pointer, @workingjubilee! I'll take a look.

  6. saethlin
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 7, 2024

  7. workingjubilee commented on Jun 10, 2024

    @workingjubilee
    workingjubilee
    on Jun 10, 2024
    MemberAuthor

    To concretize this issue slightly further, I'd like to apply changes as close as possible to the other ones in this patch to the debuginfo test suite: #125963

  8. BoxyUwU commented on Jul 2, 2024

    @BoxyUwU
    BoxyUwU
    on Jul 2, 2024
    Member

    cc #115786

  9. jieyouxu
    unassigned
    michaelwoerister
    on Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)C-bugCategory: This is a bug.O-windowsOperating system: WindowsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions