-
-
Notifications
You must be signed in to change notification settings - Fork 16.1k
improve spans for CallArgument constraints #135238
Copy link
Copy link
Open
Labels
A-borrow-checkerArea: The borrow checkerArea: The borrow checkerA-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.D-imprecise-spansDiagnostics: Spans don't point to exactly the erroneous code.Diagnostics: Spans don't point to exactly the erroneous code.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Activity
Metadata
Metadata
Assignees
Labels
A-borrow-checkerArea: The borrow checkerArea: The borrow checkerA-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.D-imprecise-spansDiagnostics: Spans don't point to exactly the erroneous code.Diagnostics: Spans don't point to exactly the erroneous code.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
that's a quirk of
CallArgumentconstraints. they get their span from theLocationof the call terminator; since they don't store the span of the particular argument, it gets lost in diagnostics. that said, it does look like we have the spans of each argument inTypeChecker::check_call_inputs, so they could store that.Originally posted by @dianne in #133858 (comment)