Repository navigation
Refactorings for rustc_codegen_ssa #56108
Description
This is a list of things I noticed in rustc_codegen_{utils,ssa} which I did like to be changed.
- Move https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_utils/symbol_names/index.html to
rustc_codegen_ssa. - Remove https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_codegen_utils/lib.rs.html#64 (now unused)
- https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/debuginfo/enum.FunctionDebugContext.html
- Inline
debuginfo_disabled_messageandshould_be_ignored_messageintoas_ref.
- Inline
- https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/debuginfo/struct.FunctionDebugContextData.html
- Remove the
Cellfrom the fieldsource_locations_enabledand adapt several functions to take a mutable reference toFunctionDebugContext{,Data}instead.
- Remove the
Edit:
- https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/backend/trait.BackendTypes.html
Contextis not used insiderustc_codegen_ssa -
https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/type_/trait.BaseTypeMethods.htmlhttps://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/context/struct.CodegenCx.html#method.set_struct_body Why isset_struct_bodyeven a thing? - https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/consts/trait.ConstMethods.html All methods take &self, but a codegen backend may need to mutate stuff to create values.
- https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/statics/trait.StaticMethods.html All methods take &self, but a codegen backend may need to mutate stuff to create values.
Edit: update for current status
Activity
bjorn3 commentedon Nov 20, 2018
cc @eddyb
eddyb commentedon Nov 20, 2018
I agree with all of these.
There are also comments on #55627 that were left unaddressed, to avoid bitrot, that could be done now.
cc @denismerigoux @sunfishcode @michaelwoerister
Auto merge of #56198 - bjorn3:cg_ssa_refactor, r=eddyb
bjorn3 commentedon Apr 17, 2019
The following comments from #55627 by @eddyb likely still need to be addressed (none confirmed yet, because of the amount)
bjorn3 commentedon Mar 12, 2020
@rustbot modify labels:+A-cranelift