Skip to content

edition compatibility: No warning emitted for crate/macro of the same name #56684

Closed
Closed
edition compatibility: No warning emitted for crate/macro of the same name#56684
Labels
A-edition-2018Area: The 2018 editionA-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.A-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`

Description

@alexcrichton
alexcrichton
opened on Dec 10, 2018

Originally reported upstream this code:

#![warn(rust_2018_compatibility)]
#![allow(unused_imports)]

#[macro_use]
extern crate toml; // 0.4.8

mod x {
    use toml;
}

when compiled emits no warnings, but when compiled in the 2018 edition fails to compile.

This appears to have something to do with the fact that the toml crate has a toml macro perhaps? It seems unclear!

Activity

  1. alexcrichton
    added
    A-edition-2018-lints
    on Dec 10, 2018
  2. alexcrichton
    added
    A-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`
    on Jan 7, 2019

  3. ehuss commented on Mar 28, 2019

    @ehuss
    ehuss
    on Mar 28, 2019
    Contributor

    I think this can be closed. This was fixed in 1.32 via #56759.

  4. petrochenkov
    closed this as completedon Mar 28, 2019
  5. fmease
    added
    A-edition-2018Area: The 2018 edition
    A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.
    and removed
    A-edition-2018-lints
    on Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-edition-2018Area: The 2018 editionA-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.A-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions