You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@SimonSapin So ultimately, #57970 was closed meaning that we are comfortable with the specialization. If that specialization is always in place then Copied is a redundant type (and the impls that come with it are also redundant). However, keeping the cost and the Copied type also has less of a risk attached to it so there's a trade-off here. I don't know what the right choice is, but those are the facts as I see them.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
Activity
SimonSapin commentedon Feb 1, 2019
@Centril, do you feel your comment in #57126 (comment) is still an objection to the state of this feature, given the response in #57126 (comment)?
Centril commentedon Feb 1, 2019
@SimonSapin So ultimately, #57970 was closed meaning that we are comfortable with the specialization. If that specialization is always in place then
Copiedis a redundant type (and the impls that come with it are also redundant). However, keeping the cost and theCopiedtype also has less of a risk attached to it so there's a trade-off here. I don't know what the right choice is, but those are the facts as I see them.sugar700 commentedon Feb 6, 2019
@hellow554 Fixed :).
sugar700 commentedon Mar 12, 2019
For reference,
.map(|&x| x)pattern is quite common according to https://codesearch.aelve.com/rust/search?query=%5C.%5Cs*map%5Cs*%5C(%5Cs*%5C%7C%5Cs*(%3F%3A%26%5Cs*%5Cw%2B%5Cs*%5C%7C%5Cs*%5C%7B%3F%5Cs*%5Cw%2B%7C%5Cw%2B%5Cs*%5C%7C%5Cs*%5C%7B%3F%5Cs*%5C*%5Cs*%5Cw%2B)%5Cs*%5C%7D%3F%5Cs*%5C)&insensitive=off&space=off&precise=off&sources=onThis includes both Iterators and Options, because a regex match cannot separate those.
Manishearth commentedon Apr 15, 2019
@Centril Is there anything blocking stabilization here? We'd like to suggest this in Clippy, see rust-lang/rust-clippy#3958
(The crux is that
.copied()is clearer than.map(|&x| x), but.cloned()gives off the wrong impression)Centril commentedon Apr 15, 2019
@Manishearth That's not my call... =D
Picking random libs member... @sfackler is there anything blocking stabilization here?
sfackler commentedon Apr 17, 2019
Doesn't seem like it.
@rfcbot fcp merge
rfcbot commentedon Apr 17, 2019
Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
rfcbot commentedon Apr 17, 2019
🔔 This is now entering its final comment period, as per the review above. 🔔
rfcbot commentedon Apr 27, 2019
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
The RFC will be merged soon.
Auto merge of #60333 - Centril:stabilize-iterator-copied, r=varkor