Skip to content

Compile time perf regression for packed-simd's max-rss #57432

New issue
New issue
Closed
#58207
Closed
Compile time perf regression for packed-simd's max-rss#57432
#58207
Assignees
oli-obk
Labels
I-slowIssue: Problems and improvements with respect to performance of generated code.

Description

@memoryruins
memoryruins
opened on Jan 8, 2019

packed-simd's max-rss and faults regressed in #56723

https://perf.rust-lang.org/compare.html?start=ae167c91aa9abefcd4a9697b5560330ef18e2e3e&end=d6d32ac25df2984f66b6abd14c1096880e04179a&stat=max-rss

compare 2019-01-04 (ae167c9) 2019-01-04 (d6d32ac)

max-rss

packed-simd-check
	avg: 153.5%	min: 2.4%	max: 241.9%
packed-simd-opt
	avg: 119.0%	min: 2.2%	max: 229.7%
packed-simd-debug
	avg: 117.2%	min: -0.7%	max: 226.8%

faults

packed-simd-check
	avg: 149.2%	min: 0.6%	max: 235.8%
packed-simd-opt
	avg: 113.7%	min: 0.6%	max: 225.5%
packed-simd-debug
	avg: 113.6%	min: 0.6%	max: 223.3%

Other crates' max-rss were affected, although not to the extent above.

cc @oli-obk

Activity

  1. estebank
    added
    I-slowIssue: Problems and improvements with respect to performance of generated code.
    on Jan 8, 2019
  2. oli-obk
    self-assigned this
    on Jan 8, 2019
  3. emilyalbini
    added a commit that references this issue on Jan 12, 2019

    Rollup merge of rust-lang#57442 - oli-obk:lazy_const, r=RalfJung

    bff32fc
  4. Centril
    added 2 commits that reference this issue on Jan 26, 2019

    Rollup merge of rust-lang#57442 - oli-obk:lazy_const, r=RalfJung

    1dcbcb9

    Rollup merge of rust-lang#57442 - oli-obk:lazy_const, r=RalfJung

    62c863d

  5. mati865 commented on Jan 28, 2019

    @mati865
    mati865
    on Jan 28, 2019
    Member

    Looks like there were some issues with the perf but latest results show improvement for packed-simd.

  6. memoryruins commented on Jan 30, 2019

    @memoryruins
    memoryruins
    on Jan 30, 2019
    ContributorAuthor

    #57442 definitely helped :)

    https://perf.rust-lang.org/compare.html?start=01af12008d63a64446a86d995e772f8a539a4202&end=ec504def3665b0bc2ec80bede6dba2c603928315&stat=max-rss

    compare 2019-01-27 (01af120) 2019-01-28 (ec504de) % change

    max-rss

    packed-simd-check
	avg: -10.1%	min: -14.7%	max: 0.3%
packed-simd-debug
	avg: -8.5%	min: -14.2%	max: -0.1%
packed-simd-opt
	avg: -9.2%	min: -14.0%	max: -2.8%

    image

  7. nnethercote
    added a commit that references this issue on Feb 6, 2019

    Make `intern_lazy_const` actually intern its argument.

    f2871a9
  8. bors
    closed this as completedin #58207on Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

I-slowIssue: Problems and improvements with respect to performance of generated code.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions