Skip to content

Tracking issue for todo! macro #59277

Closed
Closed
Tracking issue for todo! macro#59277
Labels
A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

Description

@matklad
matklad
opened on Mar 18, 2019

This is a tracking issue for todo! macro.

Added in #56348. Feature gate: #![feature(todo_macro)].

When stabilizing, we should adjust documentation for unimplemented! to point towards todo!

Activity

  1. jonas-schievink
    added
    B-unstableBlocker: Implemented in the nightly compiler and unstable.
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on Mar 18, 2019
  2. withoutboats
    added
    A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
    T-libs-api[DEPRECATED; DO NOT USE]
    on Mar 18, 2019

  4. Centril commented on May 8, 2019

    @Centril
    Centril
    on May 8, 2019
    Contributor

    cc @alexcrichton --^ ?

  6. matklad commented on Jun 1, 2019

    @matklad
    matklad
    on Jun 1, 2019
    ContributorAuthor

    I guess we should submit stabilization PR and run FCP on that? Note that the PR needs to adjust docs for unimplemented as well. I can send the PR, but not immediately: putting out fires in rust-analyzer :D

  7. Centril
    added a commit that references this issue on Oct 3, 2019

    Rollup merge of rust-lang#61879 - stjepang:stabilize-todo, r=withoutb…

    25c6376
  8. Centril
    added a commit that references this issue on Oct 3, 2019

    Rollup merge of rust-lang#61879 - stjepang:stabilize-todo, r=withoutb…

    cc835db
  9. tmandry
    added a commit that references this issue on Oct 3, 2019

    Rollup merge of rust-lang#61879 - stjepang:stabilize-todo, r=withoutb…

    2d5f4df
  10. tmandry
    added a commit that references this issue on Oct 3, 2019

    Rollup merge of rust-lang#61879 - stjepang:stabilize-todo, r=withoutb…

    f7ee31e

  11. SimonSapin commented on Oct 18, 2019

    @SimonSapin
    SimonSapin
    on Oct 18, 2019
    Contributor

    I don’t have a strong opinion on this one, but since it landed and there doesn’t seem to be significant issues discussed since:

    @rfcbot fcp merge

  12. rfcbot commented on Oct 18, 2019

    @rfcbot
    rfcbot
    on Oct 18, 2019

    Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

    No concerns currently listed.

    Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  13. rfcbot
    added
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.
    on Oct 18, 2019

  14. rfcbot commented on Oct 21, 2019

    @rfcbot
    rfcbot
    on Oct 21, 2019

    🔔 This is now entering its final comment period, as per the review above. 🔔

  15. rfcbot
    added
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    and removed
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Oct 21, 2019
  16. rfcbot
    added
    finished-final-comment-periodThe final comment period is finished for this PR / Issue.
    on Oct 31, 2019

  17. rfcbot commented on Oct 31, 2019

    @rfcbot
    rfcbot
    on Oct 31, 2019

    The final comment period, with a disposition to merge, as per the review above, is now complete.

    As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

    The RFC will be merged soon.

  18. rfcbot
    removed
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Oct 31, 2019

  19. FlyingCanoe commented on Dec 9, 2019

    @FlyingCanoe
    FlyingCanoe
    on Dec 9, 2019

    why is this not stable wet?

  20. matklad commented on Dec 9, 2019

    @matklad
    matklad
    on Dec 9, 2019
    ContributorAuthor

    @FlyingCanoe it will be stable with Rust 1.40: https://github.com/XAMPPRocky/rust/blob/relnotes-1.40.0/RELEASES.md#stabilized-apis

  21. SimonSapin commented on Dec 9, 2019

    @SimonSapin
    SimonSapin
    on Dec 9, 2019
    Contributor

    The stabilization PR #61879 should have closed this issue. In fact it even landed before FCP in this thread was started…

  22. SimonSapin
    closed this as completedon Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions