Skip to content

x.py check should support --tests and --all #64827

Closed
Closed
x.py check should support --tests and --all#64827
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Description

@varkor
varkor
opened on Sep 27, 2019

cargo check supports these flags, but it seems x.py does not. This means issues in tests can be overlooked, as in #64813 (comment).

Activity

  1. varkor
    added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    on Sep 27, 2019
  2. Centril
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    on Sep 27, 2019

  3. Centril commented on Oct 19, 2019

    @Centril
    Centril
    on Oct 19, 2019
    Contributor

    This would have been invaluable when working on #65324.

  4. jyn514 commented on May 1, 2021

    @jyn514
    jyn514
    on May 1, 2021
    Member

    x.py check now supports --all-targets, which is a superset of --tests.

  5. jyn514
    closed this as completedon May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions