Skip to content

Nonlinearity in check_mod_privacy pass for a large number of impls #81263

Description

@weiznich

This is a followup issue to rust-lang/rustc-perf#807, where I've suggested to add diesel with the 128-column-tables enabled to the rustc-perf test-suite as this is taking quite a lot of time to compile. As part of that request we discovered that the check_mod_privacy pass scales non-linear with the number of code lines. See the linked PR for the exact numbers. I suspect that this is somehow related to a large number of trait impls for tuples of various sizes.

@rustbot modify labels: +I-slow

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-visibilityArea: Visibility / privacyC-bugCategory: This is a bug.I-slowIssue: Problems and improvements with respect to performance of generated code.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions