std: sync to dep versions of backtrace - #135070
Conversation
commented
Jan 3, 2025
commented
Jan 3, 2025
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
commented
Jan 3, 2025
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
commented
Jan 3, 2025
commented
Jan 3, 2025
|
what bug are you hunting? |
|
bootstrap and CI happily accept warnings from cargo: check which refers to: Line 35 in 319f529 where i didn't replaced adler with adler2.
|
commented
Jan 3, 2025
|
ahh. |
commented
Jan 4, 2025
|
Wow, from #135095 dist-x86_64-linux CI really don't care about warnings. |
commented
Jan 4, 2025
|
...lol. anyway, this seems fine to me. @bors r+ |
commented
Jan 4, 2025
|
The warning about adler is not so “secret” any more; I see it on the command-line every time bootstrap builds library. It's annoying that this is allowed in CI, but we should also fix the thing that it's warning about. EDIT: Warning will be fixed by #135110. |
commented
Jan 5, 2025
|
Oh, i actually forgot to push fix myself here, haha. |
Minor versions from backtrace desynced with std (they still differs in patch numbers, but still better):
https://github.com/rust-lang/backtrace-rs/blob/4d7906bb24ae91ee6587127020d360f5298f9e7e/Cargo.toml#L44-L48
There is hidden bug here, let's see if CI can find it.
cc @workingjubilee