Skip to content

Reorder passes so cfg checks are run even on private/hidden items - #147905

Closed
GuillaumeGomez wants to merge 1 commit into
rust-lang:masterfrom
GuillaumeGomez:reorder-rustdoc-passes
Closed

GuillaumeGomez wants to merge 1 commit into
rust-lang:masterfrom
GuillaumeGomez:reorder-rustdoc-passes

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Follow-up of #147809 and of #138907.

r? @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 20, 2025
@rustbot

rustbot commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

fmease is currently at their maximum review capacity.
They may take a while to respond.

@fmease

fmease commented Oct 22, 2025

Copy link
Copy Markdown
Member

Thanks! @bors r+ rollup

@bors

bors commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit ef32783 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2025
@GuillaumeGomez

Copy link
Copy Markdown
Member Author

Superseeded by #147991 (more complete tests).

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 22, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 22, 2025
@GuillaumeGomez
GuillaumeGomez deleted the reorder-rustdoc-passes branch September 16, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants