split try trait in twain

[bend-n]

View all comments

https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/on.20.60Try.60.20for.20.60.26Option.60/with/582974682

currently Try for &Option is impossible, because from_output would need to return &Option from &Self::Output. but i think there should be some way to do Option::as_ref in a generic setting, and i think this is a good cause to split the traits up a bit, like so:

pub trait Branch {
    type Output;
    type Residual;
    fn branch(self) -> ControlFlow<Self::Residual, Self::Output>;
}
pub trait FromOutput<O = <Self as Branch>::Output>: Branch {
    fn from_output(output: O) -> Self;
}
pub trait FromResidual<R = <Self as Branch>::Residual>: Branch {
    fn from_residual(residual: R) -> Self;
}
pub trait Try = Branch + FromResidual + FromOutput;
pub trait Residual<O>: Sized {
    type TryType: Try<Output = O, Residual = Self>;
}

which then allows (this is not implemented in this PR.)

impl<'a, T, E> Branch for &'a Result<T, E> {
    type Output = &'a T;
    type Residual = Result<Infallible, &'a E>;

    fn branch(self) -> ControlFlow<Self::Residual, Self::Output> { … }
}

which then allows

fn as_ref<R>(x: R) -> <R::Residual as Residual<<R as Branch>::Output>>::TryType
where
    R: Branch<Residual: Residual<<R as Branch>::Output>>
 { …  }

which then allows

let x: Result<&i32, &()> = as_ref(&Ok::<i32, ()>(1));

which i think is a great boon to Try.

[rustbot]

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[rustbot]

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @scottmcm, libs
• @scottmcm, libs expanded to 7 candidates
• Random selection from Mark-Simulacrum, jhpratt

[jhpratt]

@rustbot reroll

[bend-n]

@rustbot reroll

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[theemathas]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 65b20a9 (65b20a97de33e9e59992793a144aef2950c48c76)
Base parent: 0b63def (0b63defc8fd68957c635fe61f097b84df8fd9611)

[theemathas]

@craterbot check

[craterbot]

👌 Experiment pr-154715 created and queued.
🤖 Automatically detected try build 65b20a9
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-154715 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-154715 is completed!
📊 40 regressed and 1 fixed (1063150 total)
📊 6161 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-154715/retry-regressed-list.txt ↩

[rust-bors]

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

[bend-n]

judging from the crater run it doesnt seem there are any inference issues as was a concern in https://hackmd.io/@rust-libs/r1kfcnMQfe?stext=6977%3A100%3A0%3A1787669624%3AJrkFjm

[Mark-Simulacrum]

See my comment here - #147160 (comment) - I'm going to go ahead and close this but feel free to reach out on Zulip to coordinate next steps if you're still interested.

[bend-n]

Yeah, I read the minutes and thought about it, but I dont think i have the try-knowledge to write a whole new ACP on it unfortunately.