Fix test compiling Fuchsia with rust-under-test

[erickt]

View all comments

The rust tests for Fuchsia were disabled some time ago in #138690 when fuchsia.googlesource.com was temporarily rate limiting git checkout requests during a high period of requests. This makes a number of attempts to avoid this issue:

• It checks out Fuchsia with git filter tree:0 to reduce download size.
• It blocks downloading Fuchsia's Rust toolchain.
• It adds a number of retries to requests.
• It reduces the parallel git checkout threads.

Since it has been a while since we updated the Fuchsia integration, it also updates:

• Use the most recent commit be532c.
• It updates to the clang commit 5e63f2.
• It updates to the Fuchsia SDK version 33.20260909.5.1.
• It updates the ubuntu container to 26.04.
• It renames the test job to test-x86_64-fuchsia.
• The Fuchsia build system now requires shared libraries to be stripped.
• The Fuchsia build now requires the Rust toolchain to have the artifacts for arm64 and riscv64 to be present, even though they might not be used for this build.

Note that I did use Gemini to help debug some issues, but all the code has been written by me.

try-job: dist-various-2
try-job: test-x86_64-fuchsia

[rustbot]

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

[rustbot]

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: infra-ci
• infra-ci expanded to Kobzol, Mark-Simulacrum, jieyouxu, marcoieni, ubiratansoares
• Random selection from Mark-Simulacrum, jieyouxu, marcoieni, ubiratansoares

[erickt]

It looks like the job-linux-8c config was removed in #161562. For now I switched to using job-linux-4c to at least verify the tests are still working, but should I instead switch over to job-linux-x86-8c-ec2? Also, I saw in #162063 that the aarch64 bots might be about half as much as the x64 bots, should we switch to targeting them instead? We test that configuration in our Fuchsia tests, so it should work out of the box.

[erickt]

@bors try

[rust-bors]

💔 Test for a03d4d5 failed: CI. Failed job:

• Calculate job matrix (web logs, enhanced plaintext logs)

[rustbot]

The rustc-dev-guide subtree was changed. If your future PRs only touch the subtree, consider submitting them directly to rust-lang/rustc-dev-guide, which is where the document is primarily maintained (and has faster CI).

cc @BoxyUwU, @tshepang

[erickt]

@bors try

[rust-bors]

💔 Test for c09146d failed: CI. Failed jobs:

• try - dist-various-2 (web logs, enhanced plaintext logs)
• try - test-x86_64-fuchsia (web logs, enhanced plaintext logs)

[erickt]

Looks like I need to incorporate some changes from CI, so I switched this to a draft mode until I get the tests passing.

@bors try

[erickt]

@bors try cancel

[rust-bors]

Try build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/34911335215

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

[erickt]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: b68343f (b68343f8d1b60eda945f77f06dc69446ba3a2df9)
Base parent: 574ff7d (574ff7d98bd6d037e5236a8453029173b32631fd)

[erickt]

Sorry, it took a little iteration to get the try job ready. Unfortunately I forgot that while we are producing our toolchain on a linux arm64 machine, we don't yet support compiling fuchsia on an arm64 machine. So we'll need to stick with the x86_64 instances. From the most recent run it looks like this test takes an hour and 13 minutes, so it stays under the threshold.

[jieyouxu]

Thanks. I think there's a few things.

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[erickt]

@rustbot ready

[erickt]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 005a85e (005a85e0293b203a5d777a70526ded250896be32)
Base parent: 92801ed (92801ede88f6c10e34df6976a4cfde40142585f2)