Skip to content

Rollup of 6 pull requests - #162742

Merged
rust-bors[bot] merged 30 commits into
rust-lang:mainfrom
jhpratt:rollup-EpKtQu5
Sep 14, 2026
Merged

rust-bors[bot] merged 30 commits into
rust-lang:mainfrom
jhpratt:rollup-EpKtQu5

Conversation

@jhpratt

@jhpratt jhpratt commented Sep 14, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

devnexen and others added 30 commits March 19, 2026 20:40
on some platforms the underlying type is c_uchar,
values above 255 would silently truncate.
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
…traits-for-derive, r=estebank

Prefer exact derive imports over trait fallbacks

Fixes rust-lang#162260

r? @estebank
Fix unsound dealloc of reborrows from custom allocators

- Fixes rust-lang#162719
- Fixes rust-lang#162720
…k-Simulacrum

std::net: clamp multicast ttl value to u8 max.

on some platforms the underlying type is c_uchar,
values above 255 would silently truncate.
…lkertdev

prevent ICE from `derive` on `repr(packed)` enum

Fixes rust-lang#133025 by not generating the broken impl anymore.
Constify more Iterator and DoubleEndedIterator functions required for Range

Extracted from rust-lang#156216
Consitfies functions required for `const impl Iterator for Range`.
r? clarfonthey
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Sep 14, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 14, 2026
@jhpratt

jhpratt commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-gnu-llvm-21-3,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc-1,test-i686-msvc-2,test-armhf-gnu

@rust-bors

rust-bors Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 803c237 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 14, 2026
Rollup of 6 pull requests


try-job: dist-various-1
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-gnu-llvm-21-3
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc-1
try-job: test-i686-msvc-2
try-job: test-armhf-gnu
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 14, 2026
@rust-bors

rust-bors Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

💔 Test for ccc94bf failed: CI. Failed job:

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling glob-match v0.2.1
   Compiling citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)
    Finished `dev` profile [unoptimized] target(s) in 17.78s
     Running `target/debug/citool calculate-job-matrix`
Run type: TryJob { job_patterns: Some(["dist-various-1", "test-various", "test-x86_64-gnu-aux", "test-x86_64-gnu-llvm-21-3", "test-x86_64-msvc-1", "test-aarch64-apple-1", "test-aarch64-apple-2", "test-x86_64-mingw-1", "test-i686-msvc-1", "test-i686-msvc-2", "test-armhf-gnu"]), nolimit: false }
Error: Failed to calculate job matrix

Caused by:
    Patterns `test-i686-msvc-1, test-i686-msvc-2` did not match any auto jobs
##[error]Process completed with exit code 1.
Post job cleanup.

@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 14, 2026
@rust-bors

rust-bors Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 7s
Pushing b722b55 to main...

@rust-bors
rust-bors Bot merged commit b722b55 into rust-lang:main Sep 14, 2026
14 of 15 checks passed
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 14, 2026
@rustbot rustbot added this to the 1.100.0 milestone Sep 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b6d04e (parent) -> b722b55 (this PR)

Test differences

Show 1654 test diffs

Stage 1

  • [ui (polonius)] tests/ui/derives/derive-enum-repr-packed.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-ineffective_unstable_reexports.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/macros/derive-import-hides-trait-issue-162260.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/stability-attribute/ineffective-unstable-reexports-glob.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/stability-attribute/ineffective-unstable-reexports-grouped.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/stability-attribute/ineffective-unstable-reexports.rs: [missing] -> pass (J0)
  • [ui] tests/ui/derives/derive-enum-repr-packed.rs: [missing] -> pass (J3)
  • [ui] tests/ui/feature-gates/feature-gate-ineffective_unstable_reexports.rs: [missing] -> pass (J3)
  • [ui] tests/ui/macros/derive-import-hides-trait-issue-162260.rs: [missing] -> pass (J3)
  • [ui] tests/ui/stability-attribute/ineffective-unstable-reexports-glob.rs: [missing] -> pass (J3)
  • [ui] tests/ui/stability-attribute/ineffective-unstable-reexports-grouped.rs: [missing] -> pass (J3)
  • [ui] tests/ui/stability-attribute/ineffective-unstable-reexports.rs: [missing] -> pass (J3)
  • arc::arc_allocator_provenance::issue_162719: [missing] -> pass (J4)
  • arc::arc_allocator_provenance::issue_162720: [missing] -> pass (J4)

Stage 2

  • arc::arc_allocator_provenance::issue_162719: [missing] -> pass (J1)
  • arc::arc_allocator_provenance::issue_162720: [missing] -> pass (J1)
  • [ui] tests/ui/derives/derive-enum-repr-packed.rs: [missing] -> pass (J2)
  • [ui] tests/ui/feature-gates/feature-gate-ineffective_unstable_reexports.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/derive-import-hides-trait-issue-162260.rs: [missing] -> pass (J2)
  • [ui] tests/ui/stability-attribute/ineffective-unstable-reexports-glob.rs: [missing] -> pass (J2)
  • [ui] tests/ui/stability-attribute/ineffective-unstable-reexports-grouped.rs: [missing] -> pass (J2)
  • [ui] tests/ui/stability-attribute/ineffective-unstable-reexports.rs: [missing] -> pass (J2)

Additionally, 1632 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b722b5567eab6912db411110a2dcd7995b2d72cf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-aarch64-apple-macos-26-2: 1h 38m -> 2h 49m (+72.2%)
  2. test-x86_64-gnu-stdlib-semver-check: 10m 56s -> 18m 30s (+69.2%)
  3. test-x86_64-gnu-llvm-22-3: 1h 15m -> 2h 3m (+63.6%)
  4. test-aarch64-apple-1: 1h 32m -> 2h 19m (+50.2%)
  5. test-x86_64-gnu-stable: 1h 57m -> 2h 44m (+39.3%)
  6. dist-armv7-linux: 1h 11m -> 1h 39m (+38.9%)
  7. test-x86_64-mingw-1: 2h 15m -> 3h 8m (+38.7%)
  8. dist-ohos-aarch64: 1h -> 1h 22m (+37.4%)
  9. test-x86_64-gnu-llvm-21-2: 1h 18m -> 1h 45m (+34.8%)
  10. dist-riscv64-linux-musl: 1h 12m -> 1h 35m (+32.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (b722b55): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.2%, 0.3%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.3%, -0.1%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.5%, secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.5%, 0.5%] 1
Improvements ✅
(primary)
-2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)
-2.7% [-2.7%, -2.7%] 2
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Cycles

Results (secondary 7.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
17.0% [17.0%, 17.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 501.089s -> 498.957s (-0.43%)
Artifact size: 406.85 MiB -> 406.94 MiB (0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Sep 14, 2026
@rust-bors

rust-bors Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#162706 Prefer exact derive imports over trait fallbacks ee892f22cf33701aa4ba60c2752fe21ed3ec9c71
(link)
#162732 Fix unsound dealloc of reborrows from custom allocators b99178946642fa54394c33471a7631b2347a23c1
(link)
#154113 std::net: clamp multicast ttl value to u8 max. bc71924ad712ba345bbb3a151559f276e5990520
(link)
#161178 lint ineffective #[unstable] annotations on re-exports ed6bba929d2e45792588fc3e6d3472cc6c23b1d7
(link)
#162717 prevent ICE from derive on repr(packed) enum c5d6f600b4bec0cf1510b9c231196db6aed2ff06
(link)
#162734 Constify more Iterator and DoubleEndedIterator functions re… a4c4d95f27128ab5a2311027a0a872889dcbd385
(link)

parent commit: 4b6d04e706

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@JonathanBrouwer

Copy link
Copy Markdown
Member

@rust-timer

rust-timer commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator
Running triage with 4 benchmarks

Triage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
For this rollup, these benchmarks are:

  • ctfe-stress-5
  • deep-vector
  • tt-muncher
  • wf-projection-stress-65510

#162706 ee892f2 Prefer exact derive imports over trait fallbacks

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.3%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.8% [-2.4%, -1.1%] 4
All ❌✅ (primary) - - 0

Cycles

Results (secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.8% [2.8%, 2.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.


#162732 b991789 Fix unsound dealloc of reborrows from custom allocators

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) - - 0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#154113 bc71924 std::net: clamp multicast ttl value to u8 max.

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#161178 ed6bba9 lint ineffective #[unstable] annotations on re-exports

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.3%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162717 c5d6f60 prevent ICE from derive on repr(packed) enum

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) - - 0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162734 a4c4d95 Constify more Iterator and DoubleEndedIterator functions required for Range

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.8% [2.8%, 5.0%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-3.5%, -1.2%] 6
All ❌✅ (primary) - - 0

Cycles

Results (secondary 9.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
9.4% [2.8%, 15.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

@JonathanBrouwer

Copy link
Copy Markdown
Member

Looks like it's just noise then?
@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.