Remove usages of Unique from RawVec

[maxdexh]

View all comments

See zulip.

Probably needs a perf run, because it touches code that might be very sensitive to build times and debug mode

r? libs

[saethlin]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[rust-bors]

💔 Test for 993bb96 failed: CI, CI

[hanna-kruppe]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: b67dca9 (b67dca92df005a4ebbe8c3b45e6cfe97925fff26)
Base parent: 1936d44 (1936d44457352da43b2d740672b940ebc715ac38)

[rust-timer]

Queued b67dca9 with parent 1936d44, future comparison URL.
There is currently 1 preceding artifact in the queue.
It will probably take at least ~0.8 hours until the benchmark run finishes.

[hanna-kruppe]

Nice cleanup, I'd say "r=me if perf looks good" but we should probably do some due diligence about debug visualizers. You mentioned on Zulip that you tested manually in gdb, I can try on Windows locally later.

r? me

[hanna-kruppe]

Oh, huh, guess that a bunch of old backcompat hacks made the gdb visualizer resilient to this change:

rust/src/etc/gdb_providers.py

Line 18 in 1936d44

return ptr if ptr.type.code == gdb.TYPE_CODE_PTR else ptr[ptr.type.fields()[0]]

But the natvis looks like it’ll break:

rust/src/etc/natvis/liballoc.natvis

Line 10 in 1936d44

<ValuePointer>($T1*)buf.inner.ptr.pointer.pointer</ValuePointer>

[hanna-kruppe]

@bors try=dist-x86_64-msvc for testing

[rust-bors]

Unknown command "try". Run @bors help or go to https://bors.rust-lang.org/help to see available commands.

[hanna-kruppe]

@bors try jobs=dist-x86_64-msvc

[rust-bors]

⌛ Trying commit 4ab2802 with merge b4250fe…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/35004363157

[maxdexh]

I mean yeah that'll obviously break, I might as well fix it before the try run, no? ^^

[maxdexh]

Actually nvm this way we see if it's getting tested :D

[hanna-kruppe]

Yeah, fair point, I had the try command queued up (incorrectly, was too focused on identifying the right job name) before I dug up the natvis and didn't think before firing it off. @bors try cancel

[rust-bors]

Try build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/35004363157

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

[hanna-kruppe]

Actually nvm this way we see if it's getting tested :D

Oh yeah I guess that's a fair point too. But let me check what is the best job for running those tests.

[hanna-kruppe]

@bors try jobs=test-x86_64-msvc-*

[rust-bors]

⌛ Trying commit 4ab2802 with merge aaf1dca…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/35005035908