Conversation
rustbot
added
S-waiting-on-author
In 5d81891 ("Always inline functions signatures containing `f16` or `f128`"), these types were changed to automatically inline so codegen wouldn't crash on poorly-supported platforms. We have since gained a cfg to reflect the type's codegen reliability. Update so we only check and auto-inline based on type if this config is set, which makes `f16` and `f128` act more like any other type on most platforms. We still can't remove this entirely since a lot of API in `std` wouldn't get inlined and would crash the few remaining poorly-supported backend+target combinations.
tgross35
force-pushed
the
f16-f128-autoinline
branch
from
September 17, 2026 05:16
3006b4d to
66f69fc
Compare
Member
Author
|
PR CI covers well-supported targets, checking some that still have broken f16/f128 @bors try jobs=llvm-21,dist-powerpc-linux,test-x86_64-mingw* |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
No longer auto-inline `f16` and `f128` on well-supported platforms try-job: *llvm-21* try-job: dist-powerpc-linux try-job: test-x86_64-mingw*
tgross35
marked this pull request as ready for review
September 17, 2026 05:25
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @adwinwhite rustbot has assigned @adwinwhite. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
Assuming CI reflects my local tests, |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 5d81891 ("Always inline functions signatures containing
f16orf128"), these types were changed to automatically inline so codegen wouldn't crash on poorly-supported platforms. We have since gained a cfg to reflect the type's codegen reliability. Update so we only check and auto-inline based on type if this config is set, which makesf16andf128act more like any other type on most platforms.We still can't remove this entirely since a lot of API in
stdwouldn't get inlined and would crash the few remaining poorly-supported backend+target combinations.Followup to #133050.