Conversation
rustbot
added
S-waiting-on-review
Member
Author
|
Disclosure: An LLM was used for experiments here, but all code here is written fresh. |
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
Bot
force-pushed
the
trace-refactor
branch
2 times, most recently
from
September 17, 2026 23:05
a7b130c to
33a9201
Compare
jackh726
changed the title
lqd
approved these changes
Sep 18, 2026
| stack: Vec<PointIndex>, | ||
| } | ||
|
|
||
| struct DropData<'tcx> { |
Member
There was a problem hiding this comment.
Apologies in advance for being annoying: the borrowck crate has a lot of entangled and undocumented stuff, and IMO a practical way to fix it is for every change to leave things in a slightly better state. Add missing documentation, fix comments, simplify and clarify code when we can, etc.
This absence is pre-existing, but let's document DropData now.
Member
Author
There was a problem hiding this comment.
Added a comment - let me know if that works for you.
lqd
reviewed
Sep 18, 2026
rust-cloud-vms
Bot
force-pushed
the
trace-refactor
branch
from
September 18, 2026 17:46
56099cd to
2ddd796
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor enables splitting out some liveness calculation to be deferred.
r? lqd