Rollup of 19 pull requests - #162989
Rollup of 19 pull requests#162989
Conversation
expectations not fulfulling
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
…ctly long double (i.e. f128) is special-case in the sparc abi
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
there's no need to wrap the value at runtime to visit it
- fix margins - ensure the MIR code wraps instead of needing scrollbars - defocus the trace suffixes
This updates the rust-version file to da51146.
This updates the rust-version file to 32d94cc.
This reverts commit 102f03d2c410660a45d0231fdafdd347e0d4e77f.
This comment has been minimized.
This comment has been minimized.
…uwer Rollup of 19 pull requests Successful merges: - #160401 (sparc: make ABI consistent with clang) - #162715 (don't calculate dtors if the self ty has impossible bounds) - #162740 (stdarch subtree update) - #162946 (Simplify query stack printing) - #161005 (fix: unfulfilled nested dead code lint) - #161246 (Normalize non-rigid aliases in ty_known_to_outlive) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162661 (simplify `Target::GenericParam`) - #162666 (Tidy footnote in `platform-support.md`) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162879 (use u64 limbs in core::num::bignum) - #162903 (PassWrapper: adapt to LLVM reading exception model from module flag) - #162905 (c-variadic: add checks for windows i686) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162929 (Update unicode_data to Unicode version 18.0.0) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound) - #162960 (Guard types with unstable `Allocator` params ahead of partial stabilization)
|
💔 Test for ef75812 failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 420ed2a (parent) -> 971903d (this PR) Test differencesShow 1135 test diffsStage 1
Stage 2
(and 1 additional test diff) Additionally, 1034 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 971903d9aee24befd88423f42826c232e27c8190 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (971903d): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 4.1%, secondary 1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 498.333s -> 496.358s (-0.40%) |
|
📌 Perf builds for each rolled up PR:
parent commit: 420ed2a0c3 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
#162879 was probably the improvements, queued a build at #162879 (comment) |
…ieyouxu Temporarily disable `test-x86_64-fuchsia` Since we seem to be overwhelming unauthenticated servers (e.g. rust-lang#162989 (comment)). ``` Error 503 (Service Unavailable)!!1 ``` So let's disable for now. Tracked in rust-lang#162999. Also discussed in https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/near/625351251. r? me
|
As a tip, you can also do |
Running triage with 16 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
#160401 3edd7a7 sparc: make ABI consistent with clangThis perf run didn't have relevant results for the `instruction count` metric.Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. #162715 baddcd6 don't calculate dtors if the self ty has impossible boundsThis perf run didn't have relevant results for the `instruction count` metric.Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 8.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 9.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. #162740 a39638f stdarch subtree updateThis perf run didn't have relevant results for the `instruction count` metric.Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. #161005 8b750f2 fix: unfulfilled nested dead code lintInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. #161246 ab204d9 Normalize non-rigid aliases in ty_known_to_outliveThis perf run didn't have relevant results for the `instruction count` metric.Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. #162903 e690d58 PassWrapper: adapt to LLVM reading exception model from module flagThis perf run didn't have relevant results for the `instruction count` metric.Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. #162922 8b4da8d An assortment of polonius tweaksInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (primary -2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. #162929 0eb94af Update unicode_data to Unicode version 18.0.0This perf run didn't have relevant results for the `instruction count` metric.Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeResults (primary -0.1%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
#162930 baa60f9 Use niche length type for strlen to guarantee
|
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.2%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
Results (secondary 2.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
2.7% | [2.7%, 2.7%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
This perf run didn't have relevant results for this metric.
Rollup merge of #163001 - jieyouxu:temp-disable-fuchsia, r=jieyouxu Temporarily disable `test-x86_64-fuchsia` Since we seem to be overwhelming unauthenticated servers (e.g. #162989 (comment)). ``` Error 503 (Service Unavailable)!!1 ``` So let's disable for now. Tracked in #162999. Also discussed in https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/near/625351251. r? me
Successful merges:
RELEASES.mdto themainbranch #162256 (Add mentions to sync backRELEASES.mdto themainbranch)Target::GenericParam#162661 (simplifyTarget::GenericParam)platform-support.md#162666 (Tidy footnote inplatform-support.md)NonZero::from_str#162803 (docs(num): add documentation forNonZero::from_str)rustdoc-htmltests in the right location #162906 (Move morerustdoc-htmltests in the right location)isize::MAXbound #162930 (Use niche length type for strlen to guaranteeisize::MAXbound)Allocatorparams ahead of partial stabilization #162960 (Guard types with unstableAllocatorparams ahead of partial stabilization)r? @ghost
Create a similar rollup