Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
rust-lang
/
rust
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
16.3k
Star
119k
Code
Issues
5k+
Pull requests
1.4k
Actions
Projects
Security and quality
6
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
parse: unify item parsing & filter illegal item kinds
- #69366
#69366
Merged
bors
merged 17 commits into
rust-lang:master
rust-lang/rust:master
from
Centril:unified-items
Centril/rust:unified-items
Copy head branch name to clipboard
Feb 24, 2020
Conversation
Commits
17
(17)
Checks
Files changed
Merged
parse: unify item parsing & filter illegal item kinds
#69366
bors
merged 17 commits into
rust-lang:master
rust-lang/rust:master
from
Centril:unified-items
Centril/rust:unified-items
Copy head branch name to clipboard
Commits
Commits on Feb 23, 2020
add `Span` to `ast::Defaultness::Default`.
Centril
committed
fa2a792
View commit details
Copy full SHA for fa2a792
Browse repository at this point
`parse_defaultness`: avoid hardcoded list of keywords.
Centril
committed
d41fc13
View commit details
Copy full SHA for d41fc13
Browse repository at this point
ast: add `Defaultness` to `Item`, making `AssocItem` an alias.
Centril
committed
7017058
View commit details
Copy full SHA for 7017058
Browse repository at this point
parse: extract `error_on_unmatched_vis`.
Centril
committed
9ed4c09
View commit details
Copy full SHA for 9ed4c09
Browse repository at this point
parse: recover `default` on free items.
Centril
committed
a920a05
View commit details
Copy full SHA for a920a05
Browse repository at this point
parse: use `parse_item_common` in `parse_foreign_item`.
Centril
committed
a63f35d
View commit details
Copy full SHA for a63f35d
Browse repository at this point
parse: use `parse_item_common` in `parse_assoc_item_`.
Centril
committed
a05c83b
View commit details
Copy full SHA for a05c83b
Browse repository at this point
parse: move token hack into `parse_item_common`.
Centril
committed
a3b0829
View commit details
Copy full SHA for a3b0829
Browse repository at this point
parse: harden `default` test.
Centril
committed
abc46a5
View commit details
Copy full SHA for abc46a5
Browse repository at this point
parser: refactor away at_end
Centril
committed
d446c73
View commit details
Copy full SHA for d446c73
Browse repository at this point
parser: tweak unmatched wording
Centril
committed
ab84914
View commit details
Copy full SHA for ab84914
Browse repository at this point
parser: tweak item kind wording
Centril
committed
b01c1e2
View commit details
Copy full SHA for b01c1e2
Browse repository at this point
parse: `NtItem` -> `parse_item_common`.
Centril
committed
842027f
View commit details
Copy full SHA for 842027f
Browse repository at this point
parse/ast: move `Defaultness` into variants.
Centril
committed
62930d3
View commit details
Copy full SHA for 62930d3
Browse repository at this point
parse: tweak `parse_item_` for more reuse.
Centril
committed
e66a39b
View commit details
Copy full SHA for e66a39b
Browse repository at this point
parse: tweak diagnostic wordings
Centril
committed
fde5939
View commit details
Copy full SHA for fde5939
Browse repository at this point
parse: test bad variants wrt. issue 48137.
Centril
committed
1c75f5a
View commit details
Copy full SHA for 1c75f5a
Browse repository at this point
You can’t perform that action at this time.