Stop keeping metadata in memory before writing it to disk - #96544

Merged

bors merged 32 commits into

rust-lang:masterfrom

m-ysk:feature/issue-96358

Jul 15, 2022

Commits on Jul 2, 2022

move emit_metadata to rustc_metadata::fs
m-ysk
committed
709a782
move encode_and_write_metadata to rustc_metadata::fs
m-ysk
committed
5d9ba49
use rustc_serialize::opaque::FileEncoder
m-ysk
committed
e7f95ac
call emit_metadata only when metadata_kind is None
m-ysk
committed
bb75c4b
construct EncodedMetadata in encode_and_write_metadata
m-ysk
committed
c26c461
hold Mmap in EncodedMetadata
m-ysk
committed
8cfa7ca
write to a temporary file in Decodable for EncodedMetadata
m-ysk
committed
336af60
seek and write the root position to the metadata file
m-ysk
committed
34f8889
use BufReader for counting zero bytes
m-ysk
committed
1be5805
add Send to the argument type of encode_metadata
m-ysk
committed
aa8e064
fix a typo
m-ysk
committed
1c2cc68
import all necessary parts of rustc_metadata::fs
m-ysk
committed
5aac75a
remove non_durable_rename in rustc_interface::util
m-ysk
committed
b28b7c9
write the root position at the end
m-ysk
committed
c8e49e4
call EncodedMetadata::empty in case of MetadataKind::None
m-ysk
committed
1ead92d
seek before counting zero bytes
m-ysk
committed
e11dd80
insert dummy 4 bytes to avoid the breaking change
m-ysk
committed
8d35ff1
create tmp directory if there is no parent directory
m-ysk
committed
dcb599f
use &Path instead of AsRef<Path>
m-ysk
committed
47c3689
define MmapMut and use it in Decodable impl
m-ysk
committed
c57d778
flush and assert when counting zero bytes
m-ysk
committed
7eb64b4
create an empty file even in case of MetadataKind::None
m-ysk
committed
03de5c4
add a comment about the drop order for EncodedMetadata
m-ysk
committed
ec64b4c
Revert "write the root position at the end"
m-ysk
committed
34e44e5
refactor encode_and_write_metadata
m-ysk
committed
0928061
fix an incorrect filename for an error message
m-ysk
committed
63dec94
add some comments for encode_and_write_metadata
m-ysk
committed
ad55481
add a comment about counting zero bytes
m-ysk
committed
3e30935
avoid holding the temp_dir for empty metadata file
m-ysk
committed
ea0e0f4
seek instead of opening a new file handle
m-ysk
committed
a206121
fall back on the blank path if out_filename is blank
m-ysk
committed
7a5e773

Commits on Jul 3, 2022

ensure rustc does not panic by the test for issue-26092
m-ysk
committed
1147d50

Navigation Menu

Uh oh!

Stop keeping metadata in memory before writing it to disk - #96544

Stop keeping metadata in memory before writing it to disk#96544
bors merged 32 commits into
rust-lang:masterfrom
m-ysk:feature/issue-96358

Commits on Jul 2, 2022

move emit_metadata to rustc_metadata::fs

move encode_and_write_metadata to rustc_metadata::fs

use rustc_serialize::opaque::FileEncoder

call emit_metadata only when metadata_kind is None

construct EncodedMetadata in encode_and_write_metadata

hold Mmap in EncodedMetadata

write to a temporary file in Decodable for EncodedMetadata

seek and write the root position to the metadata file

use BufReader for counting zero bytes

add Send to the argument type of encode_metadata

fix a typo

import all necessary parts of rustc_metadata::fs

remove non_durable_rename in rustc_interface::util

write the root position at the end

call EncodedMetadata::empty in case of MetadataKind::None

seek before counting zero bytes

insert dummy 4 bytes to avoid the breaking change

create tmp directory if there is no parent directory

use &Path instead of AsRef<Path>

define MmapMut and use it in Decodable impl

flush and assert when counting zero bytes

create an empty file even in case of MetadataKind::None

add a comment about the drop order for EncodedMetadata

Revert "write the root position at the end"

refactor encode_and_write_metadata

fix an incorrect filename for an error message

add some comments for encode_and_write_metadata

add a comment about counting zero bytes

avoid holding the temp_dir for empty metadata file

seek instead of opening a new file handle

fall back on the blank path if out_filename is blank

Commits on Jul 3, 2022

ensure rustc does not panic by the test for issue-26092