Skip to content

Make functions part of alloc_layout_extra (#55724) const. - #99016

Closed
Raekye wants to merge 1 commit into
rust-lang:masterfrom
Raekye:const-layout
Closed

Make functions part of alloc_layout_extra (#55724) const.#99016
Raekye wants to merge 1 commit into
rust-lang:masterfrom
Raekye:const-layout

Conversation

@Raekye

@Raekye Raekye commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Make functions part of alloc_layout_extra (#55724) const. Requires two additional feature flags: const_alloc_layout and const_try (from my understanding std already builds with many other nightly features). I added them in alphabetical order. The only implementation change is std::cmp::max has to be replaced with an explicit if expression since trait methods are not const.

@rustbot

rustbot commented Jul 7, 2022

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive

rust-highfive commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 7, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2022
@Raekye

Raekye commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

@rustbot label +T-libs-api -T-libs

I think that is correct?

@rustbot rustbot added T-libs-api [DEPRECATED; DO NOT USE] and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 7, 2022
@CAD97

CAD97 commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

Even though the changes look trivial, I recommend roll-up=iffy on this PR because seemingly noöp changes to the layout code have caused perf regressions before.

@bors

bors commented Jul 13, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #99136) made this pull request unmergeable. Please resolve the merge conflicts.

@thomcc

thomcc commented Jul 16, 2022

Copy link
Copy Markdown
Member

Hi, this is an API change and so needs to go through the ACP process, as described by the bot:

If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already.

@thomcc thomcc added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2022
@Raekye Raekye mentioned this pull request Aug 31, 2022
Closed
@JohnCSimon JohnCSimon added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Sep 11, 2022
@JohnCSimon

JohnCSimon commented Sep 11, 2022

Copy link
Copy Markdown

triage: adding blocked tag
rust-lang/libs-team#94

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2022
@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 10, 2022
@pitaj

pitaj commented Jan 29, 2023

Copy link
Copy Markdown
Contributor

@rustbot label +S-waiting-on-ACP

@rustbot rustbot added the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Jan 29, 2023
@Raekye

Raekye commented Mar 30, 2023

Copy link
Copy Markdown
Contributor Author

The constification of these methods has been merged in the (later submitted) PR #102207

@Raekye Raekye closed this Mar 30, 2023
gmhelmold added a commit to HuGR-dev/corelink-server that referenced this pull request May 16, 2026
@gmhelmold @claude
fix(corelink-py): emit -undefined dynamic_lookup on macOS extension-m…
e0918d4 
…odule build

Adds a per-crate `build.rs` that emits `cargo:rustc-link-arg-cdylib=-undefined`
+ `cargo:rustc-link-arg-cdylib=dynamic_lookup` when the `extension-module`
feature is enabled on Apple targets. Without this, `cargo build -p corelink-py
--all-features` (and `cargo build --workspace --all-features`) fail on macOS
hosts with hundreds of "Undefined symbols for architecture x86_64" errors for
every `Py*` / `_Py*` symbol — rustc no longer emits dynamic_lookup by default
for cdylib crates (rust-lang/rust#99016) and PyO3 0.24 delegates the link-arg
to downstream consumers / maturin. The fix is gated on the feature env var
and `CARGO_CFG_TARGET_VENDOR == "apple"` so Linux/Windows builds, the default
no-feature path, and cross-compilation targets are untouched. Resolves the
wave-30 P1 GA blocker called out by multiple wave-28/29 agents as pre-existing
on base 04f2dff.

Quality gates: cargo build -p corelink-py (default + extension-module +
--all-features), cargo test -p corelink-py (8/8), cargo clippy -p corelink-py
--all-targets --all-features -- -D warnings, validate_specs.py,
validate_references.py — all green. Audit:
specs/_audits/2026-05-16-corelink-py-linker-fix.md.

Signed-off-by: Gustavo Schneiter <gustavo@humangr.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomcc thomcc

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-libs-api [DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Raekye @rustbot @rust-highfive @CAD97 @bors @thomcc @JohnCSimon @pitaj @Dylan-DPC