Edition 2024 + Don't post results on members of triage runs, unless results are relevant - #2584
Merged
JonathanBrouwer merged 6 commits intoSep 16, 2026
Conversation
JonathanBrouwer
force-pushed
the
no-irrelevant-results
branch
from
September 15, 2026 21:25
95653a1 to
5b166f2
Compare
JonathanBrouwer
force-pushed
the
no-irrelevant-results
branch
from
September 15, 2026 21:33
5b166f2 to
1218c32
Compare
nnethercote
approved these changes
Sep 15, 2026
Contributor
There was a problem hiding this comment.
- If-let chains: hooray!
- Somewhat-arbitrary changes to use item sort order: boo!
(I know the latter is out of your control.)
It would have been better to do the Edition 2024 changes in one PR and the "Don't post results" change in another PR, but now that they're together I'll just r+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use an if let chain, so I upgraded the crates to edition 2024.
I recommend reviewing this commit by commit.
I did the upgrade by running
cargo fix --editionand upgraded the crates, this is the first commit.I then undid some of the changes in the first commit which were false positives, this is the second commit.
The rest of the commits should be obvious.