Conversation
|
@richerfu It's been a year and we're almost done, thanks! @kchibisov |
f414679 to
ace89b6
Compare
|
@kchibisov Hi is it possible to review this PR and give us some fallbacks? Can we add ohos platform support for winit? Thanks :) |
|
This is the first out of tree platform that we'd have. So when we will release winit 0.31.0 it will have to be done in that order
I think that's too much coordination to ask. And the whole point of asking for out-of-tree platform was that we didn't want to coordinate :-( So not sure what's best here. @kchibisov any idea? Maybe what need to be done here is to have // winit-ohos/lib.rs
pub use winit::*; // winit-ohos depends on winit and re-export everything
// But override platform
mod platform {
mod ohos;
}Then in their Cargo.toml, people would do [target.'cfg(target_env = "ohos")'.dependencies]
winit = { package = "winit-ohos", version = "0.31" }But that would still be an issue for the platform_impl module so that's not a full solution. |
changelogmodule if knowledge of this change could be valuable to usersAdd OpenHarmony support, i add a independent crate in
ohos-rsgroup. And add it as dependence for winit. Follow #4330