Conversation
25dc3ab to
8bd1bd2
Compare
8bd1bd2 to
be55a83
Compare
|
Rebased; CI errors fixed. |
Is it not better to report the integer scale rather than no scale at all? |
|
I'm not a Wayland expert, but if I understand correctly the fractional scale protocol can only be used with surfaces (i.e. windows), not displays. The base Wayland protocol only supports integer scaling. Personally I have no use for an incorrect scale factor. Does anyone else? It seems a little unlikely. The only reason I care about this API at all is because I want to be able to perform my own not-quite-linear fractional scaling before sizing the window. (Edit: I simplified my code recently to stop using this API at all by just delaying sizing of the window until after creation. It seems to work well so far but there could be issues on other platforms and/or with multiple monitors.) I can restore that if you like (with a clearer warning about fractional scaling) but I suspect it would be more likely to cause bugs than actually help. |
changelogmodule if knowledge of this change could be valuable to usersPreviously this method forced return of a result, leading to:
My primary motivation is actually the last case: I would prefer to receive
None(so that I can use a workaround) than an incorrect value (on my current screen, the existing code reports 2.0 while the actual factor is 1.45).