Repository navigation
[Docs] DIRIGO.md: record the one code change on the branch - #22
Merged
Merged
Conversation
… none DIRIGO.md said commits after snapshot 9fd4e15 "change documentation only and leave ... serve/ ... byte-identical". b906f0b (PR #16) broke that with three files under serve/, so the sentence is now false and the page has to say what actually happened. The replacement names the exception, gives its commit, states the three files, and explains why it does not move behaviour: the launcher sets CONV_ROUTE_BATCH_AFTER=4 and the resolver returns 4 for it, so the tree that served :8095 and this branch behave the same. It also gives the one command that reproduces the difference, because a claim you cannot check is the thing that went wrong here. Verified: git diff --shortstat 9fd4e15..HEAD -- serve/ = 3 files, 38 insertions, 4 deletions; src, include, sycl, metal, setup.py and CMakeLists.txt still show zero changes. No other page made the claim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DIRIGO.mdtold readers that every commit after the snapshot9fd4e15dis documentation and thatserve/isbyte-identical. Merging PR #16 (
b906f0b5) made that false: three files underserve/changed. A page that justifiesits own trustworthiness with a checkable invariant must not keep a stale one.
Result
The sentence now names the single exception, its commit, and the three files; says why it does not change behaviour (the
launcher sets
CONV_ROUTE_BATCH_AFTER=4, the resolver returns 4 for it, so the serving tree and the branch agree); andprints the command that reproduces the whole difference:
Validation
git diff --shortstat 9fd4e15d..HEAD -- serve/→ 3 files changed, 38 insertions(+), 4 deletions(-), matching thetext.
git diff --name-only 9fd4e15d..HEAD -- src include sycl metal setup.py CMakeLists.txt→ 0 files, so "every otherpath is still byte-identical" is true as written.
grep -rn 'documentation only\|byte-identical'over the branch → DIRIGO.md was the only page making the claim.Limits
stated on the page rather than implied.