Repository navigation
[Docs] Report the conv_route_batch_after fix as merged, in all four places it appears - #24
Merged
Merged
Conversation
…appears The fix landed (b906f0b), but three pages still described it as open, and one measured report never mentioned that neither of its binaries read the key at all. - docs/PERF-NEXT.md §7 said "unmerged - it must not touch serve/ on this branch". It is merged, with the resolution order, the test, and the note that it is behaviour-neutral for the deployment. - DIRIGO.md lists conv_route_batch_after as a config lever; that is only true from b906f0b onward, so the list now says so. A reader who had tried to set it from the config would otherwise trust a page that was wrong at the time. - dirigo-results/0.2.13-port/README.md: neither arm of the fork-vs-stock run read that key, so both served at the default 4. Symmetric and it does not move the comparison, but a config-only change would not have shown up - that belongs in the report, not only in the inventory. - dirigo-results/notes/improvements-2026-11-08.md: its item 1 proposed "2 vs 4 vs 6, a config key, one restart per arm". Kept as the dated record, closed with a pointer to what actually happened, including that the proposed experiment would have measured nothing. Verified: no broken link or anchor in any of the four pages, all five front-door pages still render every table, and .0.2.13-port's provenance paragraph remains accurate as written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
b906f0b5merged theconv_route_batch_afterfix, but the pages that report it still describe it as open — and the0.2.13 fork-vs-stock report never mentions that neither of its binaries read that key.
Result
docs/PERF-NEXT.md§7b906f0b5, with the resolution order (flag → config → 4), the test that pins all four cases, and the statement that it is behaviour-neutral for the deploymentDIRIGO.mdconv_route_batch_afteris only honoured fromb906f0b5; before that a config edit looked applied and was notdirigo-results/0.2.13-port/README.mddirigo-results/notes/improvements-2026-11-08.mdValidation
explicit
<a name>/<a id>anchors).8/37).
CONV_ROUTE_BATCH_AFTER=4, andresolve_batch_after(None, {"conv_route_batch_after": 4})returns 4.Limits
against the fixed server, and the report says so rather than implying it.