Repository navigation
[Docs] Say the 0.2.13 gain is server-side, not that the binaries are the same - #6
Merged
Merged
Conversation
The two trees are not the same binary: the port carries 38 files over the tag, including the engine's TUNE channel. What the battery shows is that the engine measures the same on both sides (within 1.1 % on eight legs), so the claim is now stated that way instead of implying identical binaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence was loose: it implied the two builds are identical because the gain is server-side. The port carries 38 files over v0.2.13, including the engine's TUNE channel; what the battery measured is that the engine performs the same, not that the trees match.
Now: "prefill and decode are within 1.1 % of stock on all eight engine-level legs, and the gain is a server-side one - the engine measures the same on both sides."
No numbers changed.