Repository navigation
[Docs] Say what stock and the fork share before naming the fork's difference - #8
Merged
Merged
Conversation
Two things read as if the fork invented them. MTP: the four "why it is fast" bullets were presented under a heading that now carries a fork-vs-stock comparison, so "guess, then check" looked like the fork's trick. It is not - both sides run the same engine version and the same draft layer. The section now says so up front, states that the carry changes none of the four, and names what the fork does add around drafting (per-request `spec=N` and `spec_window`, neither used by the measurement) before pointing at the server-side difference. The 28.8 GB table: it belongs to the model, not to either engine. The bullet now says that, the glossary says neither stock nor this fork creates, modifies or re-encodes it, and the one PLE file the carry does touch is named - `ple_parity`, the table's self-test, which now skips instead of failing when the model file is absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Two statements in the front page implied the fork invented things that both versions share.
"guess, then check" read as the fork's advantage. Both sides run the same engine version (0.1.59) and the same
draft layer; the fork's only drafting additions are two settings the measurement does not use.
the page said so, which invites the reader to assume we created or modified it.
Related discussion
none — documentation only.
Approach
four bullets read as a description of the engine both versions share rather than of the fork.
behaviour, the carry changes how none of them runs — and names the one PLE file the carry does touch
(
ple_parity, the table's self-test, changed to skip when the fixture is absent, not to compute differently).spec=Nandspec_window, withspec_window: 0in the measured config and GuideLLM never sendingspec— and points at the server-sidedifference that the comparison measures.
IQ4_NL, 28,800,138,240 bytes, read by stock and fork alike, not created or re-encoded by either.
Validation
Passed:
git diff --name-only v0.2.13 3512b4cce511contains no runtimePLE or draft-layer change; the PLE paths in it are
src/kernels/ple_parity.cppand its SYCL twin, and the diff isthe fixture-missing SKIP (exit 77) plus a reworded string.
--ple-ggufat the same publisher file, and thetensor geometry in that file closes to the quoted byte count.
#anchorsresolve, GitHub's Markdown APIparses 7 tables and 2 images.
Failed:
none observed.
Not run:
Limits
spec_windowwas off andspecwas never sent, so the pagestill makes no speed claim about them.