test(edit): drive oversize-line acceptance through booted kernel_edit gate - #780
Merged
Merged
Conversation
… gate The #769 editor shipped with the oversize-input bullet implemented in the app (EDIT:ERR:LINE_LONG, host-harness-proven in #779) but not driven through the booted gate. Close that final gap: - run_qemu kernel_edit session 2 now appends a 70-char line after the reopen print: the editor must reject it with EDIT:ERR:LINE_LONG, end append mode, drain the remainder to the terminator, and the following print must show the buffer byte-unchanged at the pre-append line count (new expected markers EDIT:ERR:LINE_LONG + EDIT:PRINT:3). No consent-prompt count change; the existing 90s window covers the two extra steps. - dev/building.txt documents the visible limit for users; repin the /apps/dev/building.txt sha256 in tools/disk_image_apps_dev_sha.json. App source unchanged. Ad-hoc host verification (stubbed-bridge scripted-key harness replaying the exact new session-2 flow, 12/12 checks PASS): open-existing, print(3), 70-char append -> ERR, second print still 3 byte-exact lines, exactly one write for the whole session (the later legitimate save), append/save/quit proceed after the error. Closes #769
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernel_editgate instead of host-harness evidence only.run_qemu --test kernel_editsession 2 now appends a 70-char line after the reopen print: expectsEDIT:ERR:LINE_LONG, ends append mode (drain-to-terminator), and the followingpmust show the buffer byte-unchanged (EDIT:PRINT:3, two new expected markers). The session then finishes the normal append/save/quit-clean flow.dev/building.txtdocuments the visible 63-byte line limit for users; the pinned/apps/dev/building.txtsha256 is repinned intools/disk_image_apps_dev_sha.json.user/apps/edit/main.c) is unchanged — the behavior already shipped in feat(apps): line editor for in-guest source authoring (refs #769) #779; this PR adds the booted evidence + docs.Verification
bash -n,ast.parse, heredoc-unquotedexecof the rewrittenkernel_editblock confirms exact step strings).os_*bridge + scripted key queue replaying the exact new session-2 flow, 12/12 checks PASS): reopen-existing, print(3), 70-char append ->EDIT:ERR:LINE_LONG, second print still 3 byte-exact lines, exactly one total write (only the legitimate later save), append/save/quit proceed after the error.-std=c11 -Wall -Wextra -Werror -ffreestanding -nostdinc) clean;lint.shgreen;validate_disk_image_apps_dev_sha.pyshows no drift on the repinned entry (remaining FAILs are the pre-existing local-artifact-missing vendor/tinycc: pin libtcc1.a runtime-helper source set + host drift gate (sibling of libc-deps.json, refs #408 #410) #548 class, not pins).QEMU_PASS:kernel_editremains the merged PR's CI (this host is aarch64 with no x86 QEMU).Test Plan
build-and-validategreen, incl. bootedkernel_editgate with the newEDIT:ERR:LINE_LONG/EDIT:PRINT:3markersCloses #769