Skip to content

test(edit): drive oversize-line acceptance through booted kernel_edit gate - #780

Merged
rwrife merged 1 commit into
mainfrom
feature/edit-oversize-gate-769
Sep 19, 2026
Merged

rwrife merged 1 commit into
mainfrom
feature/edit-oversize-gate-769

Conversation

@rwrife

@rwrife rwrife commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • Script + heredoc parse-checked (bash -n, ast.parse, heredoc-unquoted exec of the rewritten kernel_edit block confirms exact step strings).
  • Ad-hoc host harness (stubbed os_* bridge + scripted key queue replaying the exact new session-2 flow, 12/12 checks PASS): reopen-existing, print(3), 70-char append -> EDIT:ERR:LINE_LONG, second print still 3 byte-exact lines, exactly one total write (only the legitimate later save), append/save/quit proceed after the error.
  • Strict freestanding compile of the unchanged app (-std=c11 -Wall -Wextra -Werror -ffreestanding -nostdinc) clean; lint.sh green; validate_disk_image_apps_dev_sha.py shows no drift on the repinned entry (remaining FAILs are the pre-existing local-artifact-missing vendor/tinycc: pin libtcc1.a runtime-helper source set + host drift gate (sibling of libc-deps.json, refs #408 #410) #548 class, not pins).
  • Authoritative booted QEMU_PASS:kernel_edit remains the merged PR's CI (this host is aarch64 with no x86 QEMU).

Test Plan

  • build-and-validate green, incl. booted kernel_edit gate with the new EDIT:ERR:LINE_LONG / EDIT:PRINT:3 markers

Closes #769

… gate

The #769 editor shipped with the oversize-input bullet implemented in
the app (EDIT:ERR:LINE_LONG, host-harness-proven in #779) but not
driven through the booted gate. Close that final gap:

- run_qemu kernel_edit session 2 now appends a 70-char line after the
  reopen print: the editor must reject it with EDIT:ERR:LINE_LONG, end
  append mode, drain the remainder to the terminator, and the
  following print must show the buffer byte-unchanged at the
  pre-append line count (new expected markers EDIT:ERR:LINE_LONG +
  EDIT:PRINT:3). No consent-prompt count change; the existing 90s
  window covers the two extra steps.
- dev/building.txt documents the visible limit for users; repin the
  /apps/dev/building.txt sha256 in tools/disk_image_apps_dev_sha.json.

App source unchanged. Ad-hoc host verification (stubbed-bridge
scripted-key harness replaying the exact new session-2 flow, 12/12
checks PASS): open-existing, print(3), 70-char append -> ERR, second
print still 3 byte-exact lines, exactly one write for the whole
session (the later legitimate save), append/save/quit proceed after
the error.

Closes #769
@rwrife
rwrife merged commit a7ec5d8 into main Sep 19, 2026
3 checks passed
@rwrife
rwrife deleted the feature/edit-oversize-gate-769 branch September 19, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEMO-05: Add minimal multiline source creation and editing inside SecureOS

1 participant