Repository navigation
refactor: tighten Biome lint rules - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recommendedtoall.reactandtailwinddomains, and explicitly disable unused framework, test, project, and type-inference domains.Why
The stricter preset makes Biome report more maintainability and compatibility issues, while explicit domains prevent diagnostics from frameworks and project resolution modes this Vite application does not use. The Runner change fixes the only error-level diagnostics introduced by the preset.
Validation
node_modules/.bin/biome check src scripts vite.config.ts --max-diagnostics=none --reporter=summary— passed (49 warnings and 229 infos remain from non-recommended opinionated rules).node_modules/.bin/tsc --noEmit— passed.node_modules/.bin/vite build— passed.node_modules/.bin/vite build --ssr src/entry-server.tsx --outDir dist-ssr— passed.node scripts/prerender.mjs— passed (9 pages prerendered).git diff --check— passed.pnpm run checkandpnpm run buildcould not be completed locally because the installed Homebrew pnpm 11.15.0 hangs during startup under Node 26.5.0 (the repository declares pnpm 11.15.1). The equivalent direct binaries passed, and CI will run the repository commands in its Node 22 environment.Unresolved
Closes #28