Skip to content

refactor: tighten Biome lint rules - #29

Merged
s-yoshiki merged 1 commit into
mainfrom
agent/biome-strict-rules-28
Aug 18, 2026
Merged

s-yoshiki merged 1 commit into
mainfrom
agent/biome-strict-rules-28

Conversation

@s-yoshiki

Copy link
Copy Markdown
Owner

Summary

  • Change the generic Biome preset from recommended to all.
  • Enable the react and tailwind domains, and explicitly disable unused framework, test, project, and type-inference domains.
  • Remove legacy rule-specific suppressions after confirming they were not needed with the strict preset.
  • Rewrite the Runner stdout/stderr shim callbacks so the new strict lint rule accepts them without changing behavior.
  • Document the domain choices and suppression policy in the development guide.

Why

The stricter preset makes Biome report more maintainability and compatibility issues, while explicit domains prevent diagnostics from frameworks and project resolution modes this Vite application does not use. The Runner change fixes the only error-level diagnostics introduced by the preset.

Validation

  • node_modules/.bin/biome check src scripts vite.config.ts --max-diagnostics=none --reporter=summary — passed (49 warnings and 229 infos remain from non-recommended opinionated rules).
  • node_modules/.bin/tsc --noEmit — passed.
  • node_modules/.bin/vite build — passed.
  • node_modules/.bin/vite build --ssr src/entry-server.tsx --outDir dist-ssr — passed.
  • node scripts/prerender.mjs — passed (9 pages prerendered).
  • git diff --check — passed.

pnpm run check and pnpm run build could not be completed locally because the installed Homebrew pnpm 11.15.0 hangs during startup under Node 26.5.0 (the repository declares pnpm 11.15.1). The equivalent direct binaries passed, and CI will run the repository commands in its Node 22 environment.

Unresolved

  • No implementation issues remain. The local pnpm startup issue is environment-specific.

Closes #28

@s-yoshiki
s-yoshiki merged commit 63b9ef2 into main Aug 18, 2026
2 checks passed
@s-yoshiki
s-yoshiki deleted the agent/biome-strict-rules-28 branch August 18, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: Biomeのlintルールを厳格化する

1 participant