Repository navigation
fix(modules): mark an editable install in the distribution reader #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c00726c
perf(indexer): give a cached plugin the call graph of the index
claude f314b3f
perf(indexer): keep the call graph only for a GraphPlugin
claude 2e58e5d
perf(callgraph): log no debug line for each call or definition
claude 2457a70
Merge commit '2e58e5d97bed1d513f5bd30c1d17d12d5078e2f6' into claude/p…
claude 645c625
Mark an editable install in the distribution reader
claude 7229801
Merge remote-tracking branch 'origin/main' into claude/python-call-gr…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the environment contains an editable dependency installed from another directory (for example, a sibling library),
Editabledoes not mean its source is insideProjectFS. Dropping that distribution also removes its import names frombyTop, while the project walk never reads its code. If the project imports that library inside atryguarded byImportError,resolvenow ignores the import entirely instead of reaching the library's open node, so the library's transitive dependencies can incorrectly appear unreachable. Only omit an editable distribution after establishing that the project walk covers its source; otherwise retain it as an open node.Useful? React with 👍 / 👎.