Skip to content

Fix the findings from the review of PRs 122 to 127 - #129

Merged
Sahilb315 merged 1 commit into
mainfrom
fix/review-findings-prs-122-127
Nov 11, 2026
Merged

Sahilb315 merged 1 commit into
mainfrom
fix/review-findings-prs-122-127

Conversation

@Sahilb315

Copy link
Copy Markdown
Contributor

An independent review compared PRs #122 to #127 with the product source. This PR fixes each finding that was correct, after a second check of each one against the source and a live tenant.

Wrong or stale facts

  • endpoint_type (query-with-sql.mdx, skill products.md): SafeDep Cloud now sets it from the PMG session summary (1 developer machine, 2 CI runner, 4 Kubernetes workload). A non-GitHub CI job shows 1. The sample output is updated.
  • Enum output (query-with-sql.mdx): table and JSON output both show enum numbers. A live query returned "package_ecosystem": 2. Removed "use -o json for the enum name".
  • SQL reference (reference/sql-query.mdx): next_page_token is absent on the last page, so the example now uses jq -r '.next_page_token // empty'. Added generated_at to the JSON shape, the package_guard_sandbox_violations tenant table, and "count(*) is rejected".
  • Rule blocks: added PMG_PACKAGE_ACTION_RULE_BLOCKED (6) to the block queries in agentic-investigation.mdx, alerts.mdx (with the Slack formatter) and ci-package-blocks.mdx.
  • Shadow AI: the --import-dir example now shows openai//OpenAI. A real vet scan confirmed this format. Azure OpenAI and Azure AI services are added to the coverage list.
  • GitHub App: the check-fail line now says "with the default policy", which fails on CRITICAL or HIGH vulnerabilities.
  • Inventory join: query-with-sql.mdx joins on invocation_id, the same as the other pages.
  • FAQ: removed "project names must not contain invalid characters". No such rule exists.

Lost content

  • Tenant domain: SafeDep Cloud accepts only <team>.<organization>.safedep.io. All 26 two-part examples (your-company.safedep.io) now use your-team.your-org.safedep.io. concepts/tenant, authentication and endpoint-hub/inventory say where to find the domain: the Tenant ID button on the API keys settings page.
  • Links: the inventory page links authentication#cicd-pipelines and #troubleshooting. sync.mdx names the FAQ sections that hold the network, tenant and CI secret fixes.
  • Code analysis: added the --app src/main scope example, which excludes test code.
  • docs-ia.md: restored the package-exclusions deprecation note and the /changelog redirect note.

IA files and labels

  • CLAUDE.md, docs-ia.md and the docs skill now use the group names in docs.json. They also list 7 tabs, describe the Core Concepts layout, and mark build-your-own-queries as moved.
  • concepts/policy is now a flat Core Concepts page, because it covers both kinds of policy. The nested Cloud Policy group keeps the four cloud policy concepts.
  • Threat Intel: the pagination sidebar label is "Pagination & Sync", and the connecting description no longer lists JSON conventions.

Not changed

  • Review item D2 ("xBOM" in the xBom quickstart label) is correct as it is: xBOM is the document type.
  • Two items were dropped on purpose in Merge duplicate pages and move pages to their outcome tabs #125, so they stay removed: the xBom card on the Shadow AI page and "such as Claude Code".
  • The CrowdStrike SIEM script (downloads/ingest-sd-ngsiem.py) ingests only malicious and cooldown blocks, not rule blocks. Changing the script is a separate change.
  • Not verified: the default policy revision that runs in production.

Checks

  • An independent subagent checked each changed claim, anchor and group name against the source. It found no wrong claims and no lost content, and its polish items are applied.
  • mintlify broken-links shows only the 3 known essentials/ failures.
  • No em dashes on added .mdx lines.

🤖 Generated with Claude Code

- SQL: endpoint_type values, enums as numbers, last-page token, sandbox table, count(*)
- Add PMG_PACKAGE_ACTION_RULE_BLOCKED to the block queries
- Use the three-part tenant domain form everywhere
- Fix the Shadow AI example, GitHub App check line, and anchors
- Sync CLAUDE.md, docs-ia.md and the docs skill with docs.json

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@safedep

safedep Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

View complete scan results →

This report is generated by SafeDep GitHub App

@Sahilb315
Sahilb315 merged commit a1e5770 into main Nov 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants