fix: drop Node 18/20 support, require >=22 @W-23388103@#2829
Closed
WillieRuemmele wants to merge 1 commit into
Closed
fix: drop Node 18/20 support, require >=22 @W-23388103@#2829WillieRuemmele wants to merge 1 commit into
WillieRuemmele wants to merge 1 commit into
Conversation
WillieRuemmele
force-pushed
the
wr/dropNode18And20Support
branch
2 times, most recently
from
July 15, 2026 18:12
87d5be8 to
110595f
Compare
…388103@ - Bump engines.node to >=22.0.0 (drops EOL Node 18/20) - Add --targets win32-x64,win32-arm64 to pack:win; Node 24 (bundled at build time) no longer ships 32-bit Windows binaries
WillieRuemmele
force-pushed
the
wr/dropNode18And20Support
branch
from
July 15, 2026 18:34
110595f to
1229acc
Compare
Contributor
Author
|
Closing — changing our approach to dropping Node 18/20 support (W-23388103). This declarative engines-only bump is being superseded; a new strategy will follow. Not merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engines.nodefrom>=18.0.0to>=22.0.0@jsforce/jsforce-node@3.10.17pullingundici@^8.5.0(requires Node >=22)win32-x86(32-bit Windows) build by passing--targets win32-x64,win32-arm64topack:win. The standalone builds move to Node 24, which no longer ships 32-bit Windows binaries. Telemetry shows 32-bit Windows is ~0.01% of CLI usage (~350 machines), and ~84% of those were already on EOL Node and non-functional on current releases.Fixes forcedotcom/cli#3596
Related forcedotcom/cli#3603
Work Item
@W-23388103@: [CLI] Use node v24, deprecate 18 and 20
Merge / sequencing note
The
win32-x86removal pairs with bundling Node 24 (deleting theNODE_VERSION_OVERRIDErepo variable, or setting it to24.x). Node 24 has nowin-x86binary. Note: oclif already auto-skipswin32-x86when the bundled Node is>24.0.0, so the explicit--targetsflag makes the intent clear and also drops x86 while still pinned to Node 22. After merge + var deletion, trigger a nightly and confirm only x64/arm64 Windows tarballs upload.Test plan