Skip to content

Replace decimal year conversions with julian year conversions. - #382

Open
sblunt wants to merge 18 commits into
v4from
decimalyear-to-julianyear
Open

sblunt wants to merge 18 commits into
v4from
decimalyear-to-julianyear

Conversation

@sblunt

@sblunt sblunt commented Oct 8, 2024

Copy link
Copy Markdown
Owner

See issue #372. This doesn't have any big impact on the Hipparcos IAD refitting, but maybe it affects things on longer timescales (i.e. hipparcos-gaia). Will continue to investigate.

@sblunt
sblunt requested a review from semaphoreP October 8, 2024 21:37

@semaphoreP semaphoreP left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it generally looks good to me. Did you have a chance to run an HGCA orbit fit to see if it matches previous results?

Comment thread orbitize/hipparcos.py Outdated
@sblunt
sblunt changed the base branch from main to v4 September 10, 2026 19:31
@sblunt

sblunt commented Oct 15, 2026

Copy link
Copy Markdown
Owner Author

Ok, finally actually finished running a test fit, comparing with Hsu+ 2024 (case HGCA + no RVs). Here are my results:

sma1: 21.491 +4.059 / -3.620 au
ecc1: 0.212 +0.212 / -0.154
inc1: 43.180 +6.234 / -12.544 deg
aop1: 187.946 +111.395 / -117.375 deg
pan1: 199.073 +52.460 / -146.884 deg
tau1: 0.267 +0.200 / -0.128
plx: 37.896 +0.026 / -0.027 mas
m1: 47.1 +14.7 / -5.2 Mjup
m0: 1.110 +0.088 / -0.086 Msun

and Dino's results:

sma1: 19 +4 / -3
ecc1: 0.18 +0.19 / -0.13
inc1: 39 +7 / -14
plx: 37.9 +0.03 / -0.03
aop: 134 +202 / -113
pan: 54 +17 / -17
tau1: 0.4 +0.3 / -0.08
m1: 35 +5 / -3 Mjup
m0: 1.16 +0.09 / -0.09

They're surprisingly different! These are more similar to the orvara results (https://iopscience.iop.org/article/10.3847/1538-4357/ada3be), so I wonder if this is actually the root cause. I could do an apples-to-apples comparison fit with the orvara fit (including the same RVs) to be sure.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants