Repository navigation
hotfix for brandt_correction breaking save/load - #449
Merged
Merged
Conversation
Owner
Author
|
Ignore the one failing test; I upped the number of mcmc steps in #426 which fixes that issue. |
Owner
Author
|
Nvm, I ended up fixing it here too. |
…multiplanet self conisistency fit)
… test pass without increasing step # again
Owner
Author
|
Great, unit tests are passing. The notebooks are still failing, but that's on v4, and we'll separately work on a fix. I'll pull this in now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the error introduced to save/load with the brandt_correction kwarg in hipparcos, and saves this attribute