Repository navigation
Fetch only new rows in live views; fix select mode - #87
Merged
Merged
Conversation
The selected run in History, Dashboard and Compare each refetched every row of a live run on each refresh, and History also redrew all of them, even while its tab was hidden. A 5-hour run reached tens of thousands of DOM elements, and the cost grew for as long as the run lasted. - RunRowsReader keeps a rowid cursor per run and fetches only what's been added. The scanner only appends; edits and deletes are user actions, which reload in full. Rowids, because recorded_at strings have a variable number of fractional digits and don't compare in time order. - History's coin/min, GC and wave skip tables render 100 rows per page. - Revealing a row scrolls the table's own box, not the page, so selecting a point on the chart no longer takes the chart off screen. - Dashboard takes the wave from the scanner event rather than a ref the render hasn't updated yet, which reacted one tick late. - Replace run_snapshots, run_wave_skips, run_dashboard_data and current_run_dashboard with run_rows, and drop the server-side sampling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The hover highlight was drawn over the point under the mouse and took the click, so clicking a coin/min point did nothing. - Map a drag through the axes' scales. It used the run's coin range, but the axis starts at 0 and rounds up, so the selection didn't match the rectangle on a run whose coin/min stays well above zero. - Let a drag start on a point: hit circles covered most of a dense chart. - Count a press as a drag only after 4px, not any movement. - Shrink hit circles so GC and jump dots take fewer clicks meant for coin/min. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live views refetched every row of a live run on each refresh, and select mode on the run chart was broken. Both are in v0.4.24.
Live refresh
RunRowsReader. A refresh with 3 new rows on a 4,728-row run went from about 24 ms and 620 KB to about 0.05 ms and 400 bytes (query time and row data, measured against a real database).run_rowsreplacesrun_snapshots,run_wave_skips,run_dashboard_dataandcurrent_run_dashboard.Select mode
Testing
npm run lint,tsc, Vitest and the Rust tests pass, with new tests for the reader's races and forrun_rows_after.This may help a tester's report of stutter while WaveTrace has focus, but that isn't confirmed.
🤖 Generated with Claude Code