Record shipped prompt-attachment evidence in the parity ledger - #416
Merged
Merged
Conversation
The prompt-attachments slice (PR #415) landed the native picker, staged ingestion, and daemon wire encoding, but the parity matrix had no row or evidence mentioning attachments at all, so the ledger under-recorded what actually shipped. Fold the evidence into the existing Node creation sheet row, where the macOS attachment affordance lives, and keep the row Partial: clipboard paste and drag-and-drop are still unimplemented, and the live file-picker interaction is not exercised by the UI Automation gate, so picker behavior rests on unit coverage rather than live evidence. Documentation only; no status upgrades and no code changes. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The prompt-attachments slice (#415) landed the native picker, staged ingestion, and daemon wire encoding, but
investigation/ui-parity-matrix.mdcontained no row or evidence mentioning attachments at all. The ledger is the parity source of truth, so it under-recorded what shipped.This folds the evidence into the existing Node creation sheet row, where the macOS attachment affordance lives.
The row deliberately stays Partial. Clipboard paste and drag-and-drop are not implemented, and the live file-picker interaction is not exercised by the UI Automation gate (the gate opens the node form and closes it without invoking Attach), so picker behavior rests on unit coverage rather than live evidence. No status is upgraded and no code changes.
Validation
RED: git show b974769:investigation/ui-parity-matrix.md piped to Select-String for PromptAttachment/IFileOpenDialog/DraftAttachments -> 0 matches, confirming the shipped attachments work was entirely absent from the parity ledger
GREEN: Select-String for PromptAttachment/IFileOpenDialog/DraftAttachments over the updated investigation/ui-parity-matrix.md -> 1 match, recording the picker, staged ingestion, wire shape, and the explicit unimplemented/unverified caveats
REGRESSION: parsed the status column of every ledger table row before and after the edit -> rows=94 Blocked=2 Partial=41 Validated=51 identical on both sides, proving the table structure is intact and no row was silently upgraded